Use KRadioButtonGroup in the language switcher modal and on the Device settings page

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education

https://learningequality.org/kolibri/

MIT License

779 stars 647 forks source link

Use KRadioButtonGroup in the language switcher modal and on the Device settings page #12325

Closed muditchoudhary closed 3 weeks ago

muditchoudhary commented 3 months ago

Summary

…

References

Reviewer guidance

…

Testing checklist

[ ] Contributor has fully tested the PR manually
[ ] If there are any front-end changes, before/after screenshots are included
[ ] Critical user journeys are covered by Gherkin stories
[ ] Critical and brittle code paths are covered by unit tests

PR process

[ ] PR has the correct target branch and milestone
[ ] PR has 'needs review' or 'work-in-progress' label
[ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
[ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
[ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

Automated test coverage is satisfactory
PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

muditchoudhary commented 3 months ago

Hi @pcenov @radinamatic could you please QA test now? I fixed the tab issue on the change language modal.

cc: @MisRob

github-actions[bot] commented 3 months ago

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.17.0a0.dev0_git.222.g4ab4d29e.pex
Windows Installer (EXE)	kolibri-0.17.0a0.dev0+git.222.g4ab4d29e-windows-setup-unsigned.exe
Debian Package	kolibri_0.17.0a0.dev0+git.222.g4ab4d29e-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.17.0a0.dev0+git.222.g4ab4d29e.dmg
Android Package (APK)	kolibri-0.17.0a0.dev0+git.222.g4ab4d29e-0.1.4-debug.apk
TAR file	kolibri-0.17.0a0.dev0+git.222.g4ab4d29e.tar.gz
WHL file	kolibri-0.17.0a0.dev0+git.222.g4ab4d29e-py2.py3-none-any.whl

MisRob commented 3 months ago

Thanks @muditchoudhary!

For QA, test instructions are written here https://github.com/learningequality/kolibri/pull/12243

pcenov commented 3 months ago

Thanks a lot @muditchoudhary! @radinamatic I confirm that tab navigation through the radio buttons in the language modal is working correctly in Firefox:

https://github.com/learningequality/kolibri/assets/79847249/92984660-e0c7-48d0-9f2a-20d35202ec7b

muditchoudhary commented 3 months ago

Thank you @pcenov

MisRob commented 1 month ago

@radinamatic @pcenov Could you please re-test this PR? I've tried briefly and looked good to me.

MisRob commented 1 month ago

Actually we will need one more code adjustment, so let's wait for final version before QA. I will let you know when it's ready @radinamatic @pcenov

MisRob commented 1 month ago

Thanks for getting everything ready here @muditchoudhary! @radinamatic @pcenov it's ready for final QA :)

pcenov commented 1 month ago

Hi @MisRob - no issues observed while manually testing - good to go!

MisRob commented 1 month ago

Thanks! We merged the KDS PR. As soon as the new KDS release is ready, I will install it here and we can merge.

MisRob commented 3 weeks ago

Briefly re-tested on the most recent build, all good

MisRob commented 3 weeks ago

Yey @muditchoudhary, it's live now!

muditchoudhary commented 3 weeks ago

Yayy!! Thank you for telling me @MisRob