learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
755 stars 637 forks source link

Refactored HomePage route handler to fetch initClassInfo and getFacil… #12358

Open shubh1007 opened 5 days ago

shubh1007 commented 5 days ago

Summary

This is the continuation of the refactoring process for the coach page, transitioning from a global route handler to local route handlers. #11219

References

List of all planRoutes:

Route name Handler/component to refactor Refactor done? How to test the page
PageNames.HOME_PAGE showHomePage yes Coach -> Class Home
HomeActivityPage.name showHomePage yes Coach -> Class Home -> activity

Reviewer guidance

Please follow the table for reviewing the refactored routes.

Testing checklist

PR process

Reviewer checklist

MisRob commented 5 days ago

Hi @shubh1007, this is great! I can see you grasped the problem and the strategy for solving it, thanks a lot. This will really help us to unblock some important work. Leaving just a few details, but overall looks really good.

Do you wish to continue with some other routes from this file? If so, would you push them to this PR as well or would you rather work in a new one?

Note that I'm mostly offline until July 8 - just chiming in on this issue to confirm that you can continue if you'd like, and on some days I will be available to answer questions.

github-actions[bot] commented 5 days ago

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0a0.dev0+git.130.g3acb0c2a-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0a0.dev0+git.130.g3acb0c2a-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0a0.dev0+git.130.g3acb0c2a-0.4.2.dmg
Android Package (APK) kolibri-0.17.0a0.dev0+git.130.g3acb0c2a-0.1.3-debug.apk
TAR file kolibri-0.17.0a0.dev0+git.130.g3acb0c2a.tar.gz
WHL file kolibri-0.17.0a0.dev0+git.130.g3acb0c2a-py2.py3-none-any.whl