learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
755 stars 637 forks source link

Fix question listing and navigation in quiz reports #12359

Closed rtibbles closed 2 days ago

rtibbles commented 5 days ago

Summary

References

Fixes #12334

Reviewer guidance


Testing checklist

PR process

Reviewer checklist

github-actions[bot] commented 5 days ago

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0a0.dev0+git.152.ge847da8b-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0a0.dev0+git.152.ge847da8b-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0a0.dev0+git.152.ge847da8b-0.4.2.dmg
Android Package (APK) kolibri-0.17.0a0.dev0+git.152.ge847da8b-0.1.3-debug.apk
TAR file kolibri-0.17.0a0.dev0+git.152.ge847da8b.tar.gz
WHL file kolibri-0.17.0a0.dev0+git.152.ge847da8b-py2.py3-none-any.whl
pcenov commented 4 days ago

Hi @rtibbles, everything seems ok but noticed 2 issues that can potentially cause confusion:

  1. When all the sections are collapsed there's no indication to which section the displayed question belongs so that the learner/coach might have to expand several sections before finding out. Perhaps there should be a selection effect to the section title as well:

2024-06-26_16-22-59

  1. There's a mismatch between the question title within the section panel and the question title as displayed when viewing the details of the question. For example when I select Question 4 from the second section, it's displayed as Question 1 to the right and that's so for every new section:

https://github.com/learningequality/kolibri/assets/79847249/ad695713-7f6a-4aa5-8c27-0f402ae69c77

rtibbles commented 4 days ago

Thanks @pcenov - definitely useful to add an indicator at the section level too - I will use the same background colour.

Will make sure that the titles match!

rtibbles commented 4 days ago

Hi @pcenov I have fixed both these issues, and moved to a consistent 'global across the quiz' question numbering.

To be completely consistent, I have also updated this for learners taking the quiz too, so additional testing there would be very useful.