search

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
755 stars 637 forks source link

EQM: Bookmarks not linking anywhere in resource selection #12360

Closed nucleogenesis closed 3 days ago

nucleogenesis commented 5 days ago

Summary

Fixes #12331

The contentLink method in ResourceSelection was returning an empty object with the expectation that it would basically serve as a no-op which worked find except for the fact that we show bookmarks based on a query param.

This returns the current route's name params and query for non-topic content nodes. I think I worried that this approach would result in redundant navigation errors but it seems that router-link just ignores clicks on the links.

Reviewer guidance

Test clicking bookmarks and exercise cards in EQM resource selection.

github-actions[bot] commented 5 days ago

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0a0.dev0+git.125.g4d3a1123-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0a0.dev0+git.125.g4d3a1123-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0a0.dev0+git.125.g4d3a1123-0.4.2.dmg
Android Package (APK) kolibri-0.17.0a0.dev0+git.125.g4d3a1123-0.1.3-debug.apk
TAR file kolibri-0.17.0a0.dev0+git.125.g4d3a1123.tar.gz
WHL file kolibri-0.17.0a0.dev0+git.125.g4d3a1123-py2.py3-none-any.whl