Open rtibbles opened 5 days ago
Asset type | Download link |
---|---|
PEX file | kolibri-.pex |
Windows Installer (EXE) | kolibri-0.17.0a0.dev0+git.157.g9a03d785-windows-setup-unsigned.exe |
Debian Package | kolibri_0.17.0a0.dev0+git.157.g9a03d785-0ubuntu1_all.deb |
Mac Installer (DMG) | kolibri-0.17.0a0.dev0+git.157.g9a03d785-0.4.2.dmg |
Android Package (APK) | kolibri-0.17.0a0.dev0+git.157.g9a03d785-0.1.3-debug.apk |
TAR file | kolibri-0.17.0a0.dev0+git.157.g9a03d785.tar.gz |
WHL file | kolibri-0.17.0a0.dev0+git.157.g9a03d785-py2.py3-none-any.whl |
Hi @rtibbles, while fully regression testing I noticed just the following onscreen keyboard related issues:
https://github.com/learningequality/kolibri/assets/79847249/9e25231a-a2cd-45a4-8736-8011b3f2ac26
https://github.com/learningequality/kolibri/assets/79847249/1bfc9f98-c79c-44c0-b124-8dc4edf5889d
Also I am not sure whether the issue described in https://github.com/learningequality/kolibri/issues/12322 sis fully fixed as I would expect that if the keyboard is present on screen then the input focus should be within the input field, which is still not the case:
https://github.com/learningequality/kolibri/assets/79847249/268b9ff5-7486-4d1e-82c7-0cc7b65384b6
More troubling is you are still seeing the console errors that my fix was meant to prevent, I still haven't replicated these without your database directly, so I feel like I am missing something in the steps to replication here.
Summary
References
Fixes #12322 Fixes #12375
Reviewer guidance
Use the database from referenced issue and see that the quiz responses are properly restored for all questions with no errors logged in the console. While on the quiz page, refresh the page, and see that the answer gets properly filled in on page refresh.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)