EQM: Difficult questions reports fix

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education

https://learningequality.org/kolibri/

MIT License

755 stars 637 forks source link

EQM: Difficult questions reports fix #12372

Closed nucleogenesis closed 3 days ago

nucleogenesis commented 4 days ago

Summary

Closes #12164 - where questions were needed in questionDetail/handlers.js we were still expecting the Exam.question_sources v2 schema. I did a cursory search for possible other uses of question_sources to derive questions but found nothing else.

🎆 BONUS FIXES 🎆

Before:

Not all issues shown in screenshot

Broken icons
Text and icon were inline-block, weird text overflow
px values
icon is a few pixels below centered

After:

Not all fixes shown in screenshot

Proper icons
Icon vertical centered
Text is padded from left, justified against icon's spacing
Icon absolute positioned
em values

Reviewer guidance

[ ] Can you view Difficult questions reports?
[ ] Does the page have working icons that look right?

github-actions[bot] commented 4 days ago

Build Artifacts

Asset type	Download link
PEX file	kolibri-.pex
Windows Installer (EXE)	kolibri-0.17.0a0.dev0+git.144.gc090b4c0-windows-setup-unsigned.exe
Debian Package	kolibri_0.17.0a0.dev0+git.144.gc090b4c0-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.17.0a0.dev0+git.144.gc090b4c0-0.4.2.dmg
Android Package (APK)	kolibri-0.17.0a0.dev0+git.144.gc090b4c0-0.1.3-debug.apk
TAR file	kolibri-0.17.0a0.dev0+git.144.gc090b4c0.tar.gz
WHL file	kolibri-0.17.0a0.dev0+git.144.gc090b4c0-py2.py3-none-any.whl

pcenov commented 3 days ago

Hi @nucleogenesis I confirm that now it's possible to see the details of the difficult questions however when I go to Coach > Reports > Lesson > Difficult questions I am not seeing the incorrect answers of the learner:

https://github.com/learningequality/kolibri/assets/79847249/1bef017a-4f36-4fc5-979a-dc8930475e0e

If that's not caused by the changes made here, I can file a follow-up issue.

nucleogenesis commented 3 days ago

@pcenov I think that @rtibbles will have the issue you found resolved with his Perseus work

Thanks for giving this a look!

rtibbles commented 3 days ago

@pcenov I filed your observation as an issue, and tagged it as resolved by my PR here: https://github.com/learningequality/kolibri/pull/12362 if you could verify the fix there, that would be great!