learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
755 stars 637 forks source link

Wrap section deletion modal in focus trap #12373

Closed LianaHarris360 closed 2 days ago

LianaHarris360 commented 3 days ago

Summary

This pull request includes the addition of FocusTrap to CreateQuizSection in order to maintain focus within the section deletion confirmation modal. Additionally, it addresses the bug where selecting the cancel button failed to exit the modal.

https://github.com/learningequality/kolibri/assets/46411498/5727d518-b834-49da-8f82-09c48556ee4f

References

Fixes #12303

Reviewer guidance

  1. Create a new quiz.
  2. Select options within a section and press delete section.
  3. Use the tab key to navigate between CANCEL to DELETE.
  4. Confirm that selecting CANCEL closes the modal.

Testing checklist

PR process

Reviewer checklist

github-actions[bot] commented 3 days ago

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0a0.dev0+git.149.g0faf7615-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0a0.dev0+git.149.g0faf7615-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0a0.dev0+git.149.g0faf7615-0.4.2.dmg
Android Package (APK) kolibri-0.17.0a0.dev0+git.149.g0faf7615-0.1.3-debug.apk
TAR file kolibri-0.17.0a0.dev0+git.149.g0faf7615.tar.gz
WHL file kolibri-0.17.0a0.dev0+git.149.g0faf7615-py2.py3-none-any.whl