learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
755 stars 637 forks source link

Card fixes #12374

Open marcellamaki opened 3 days ago

marcellamaki commented 3 days ago

Summary

Makes some mostly-cosmetic card layout and styling adjustments. Does a teensy refactor to put the learning activity chips and icon mapping into kolibri-common, which will be used in 0.18 as part of the card and refactoring work.

References

Fixes #12280 Related slack conversation

Reviewer guidance

Testing updates: content cards (both channel and resources) used in coach resources management

Learn: I refactored the "LearningActivityChip" to kolibri-common so the places where it is used in learn should be regression tested.

Screenshot 2024-06-27 at 1 53 41 PM

It's present in the resource's information side panel accessed in


Testing checklist

PR process

Reviewer checklist

github-actions[bot] commented 3 days ago

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0a0.dev0+git.153.g261c89ac-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0a0.dev0+git.153.g261c89ac-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0a0.dev0+git.153.g261c89ac-0.4.2.dmg
Android Package (APK) kolibri-0.17.0a0.dev0+git.153.g261c89ac-0.1.3-debug.apk
TAR file kolibri-0.17.0a0.dev0+git.153.g261c89ac.tar.gz
WHL file kolibri-0.17.0a0.dev0+git.153.g261c89ac-py2.py3-none-any.whl
pcenov commented 2 days ago

Hi @marcellamaki - looks great in both desktop and mobile view, couldn't spot any issues caused by the changes made here.

I'm gonna mention that I noticed the following issue with overlapping learning activity chips, which is preexisting and I'm not sure whether is not caused by anything on Studio's end:

https://github.com/learningequality/kolibri/assets/79847249/ccf1668a-dd5a-4518-a7b2-0b120a706d47

You can replicate it by going to the following resource Hoja de Reflexión para Estudiantes - Acertijos Wiixii