learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
755 stars 637 forks source link

Load channel content on remove filter #12379

Closed AlexVelezLl closed 2 days ago

AlexVelezLl commented 2 days ago

Summary

showLibrary is the method we use to load and show the channels. But if we have filters, it never sets the rootNodes array. The problem was that we were not calling that method again when we removed the filters, so if we had filters in the first render, these channels would never have been loaded.

https://github.com/learningequality/kolibri/assets/51239030/e4547885-62b8-464b-a0b7-6f23013cbc9a

References

Closes #12328.

Reviewer guidance

Replicate #12328.

Testing checklist

PR process

Reviewer checklist

github-actions[bot] commented 2 days ago

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0a0.dev0+git.154.gc7b3ebda-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0a0.dev0+git.154.gc7b3ebda-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0a0.dev0+git.154.gc7b3ebda-0.4.2.dmg
Android Package (APK) kolibri-0.17.0a0.dev0+git.154.gc7b3ebda-0.1.3-debug.apk
TAR file kolibri-0.17.0a0.dev0+git.154.gc7b3ebda.tar.gz
WHL file kolibri-0.17.0a0.dev0+git.154.gc7b3ebda-py2.py3-none-any.whl