Fix white space on top of tabs dividing line - Githubissues

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education

https://learningequality.org/kolibri/

MIT License

755 stars 637 forks source link

Fix white space on top of tabs dividing line #12380

Open AlexVelezLl opened 2 days ago

AlexVelezLl commented 2 days ago

Summary

Note: This PR depends on https://github.com/learningequality/kolibri-design-system/pull/673.

Fix white space on top of coach tabs dividing line.

References

Closes #12297.

Reviewer guidance

You can go to any of these components and see that dividing line is showing correctly:

Tabs on Coach Reports table
Tabs on Coach Plan table
Tabs on Coach Group Reports table
Tabs on Coach Learner Reports table
Tabs on Coach Lesson Reports table
Tabs on Coach Quiz Reports table

Testing checklist

[x] Contributor has fully tested the PR manually
[x] If there are any front-end changes, before/after screenshots are included
[ ] Critical user journeys are covered by Gherkin stories
[ ] Critical and brittle code paths are covered by unit tests

PR process

[x] PR has the correct target branch and milestone
[x] PR has 'needs review' or 'work-in-progress' label
[ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
[ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
[ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

Automated test coverage is satisfactory
PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md