Nav alignment - Githubissues

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education

https://learningequality.org/kolibri/

MIT License

779 stars 647 forks source link

Nav alignment #12496

Closed marcellamaki closed 2 months ago

marcellamaki commented 2 months ago

Summary

Fixes the text truncation and alignment of nav bar elements

References

Fixes #12282

Description	Screenshot
Facility Small
Coach Small
Coach medium with overflow items

Reviewer guidance

Choose a class with a long name, that also includes a facility (i.e. I tested with one that was imported and also had a class name)

check in Coach and Facility on small, medium, and large screen sizes
ensure the text truncation is present and doesn't overlap with any other screen elements
ensure that the options button for the "overflow" of menu items is always present when needed and is not ever covered by anything else

Testing checklist

[ ] Contributor has fully tested the PR manually
[ ] If there are any front-end changes, before/after screenshots are included
[ ] Critical user journeys are covered by Gherkin stories
[ ] Critical and brittle code paths are covered by unit tests

PR process

[ ] PR has the correct target branch and milestone
[ ] PR has 'needs review' or 'work-in-progress' label
[ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
[ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
[ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

Automated test coverage is satisfactory
PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

github-actions[bot] commented 2 months ago

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.17.0b3.dev0_git.45.gf335822a.pex
Windows Installer (EXE)	kolibri-0.17.0b3.dev0+git.45.gf335822a-windows-setup-unsigned.exe
Debian Package	kolibri_0.17.0b3.dev0+git.45.gf335822a-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.17.0b3.dev0+git.45.gf335822a.dmg
Android Package (APK)	kolibri-0.17.0b3.dev0+git.45.gf335822a-0.1.4-debug.apk
TAR file	kolibri-0.17.0b3.dev0+git.45.gf335822a.tar.gz
WHL file	kolibri-0.17.0b3.dev0+git.45.gf335822a-py2.py3-none-any.whl