Closed rtibbles closed 2 months ago
Asset type | Download link |
---|---|
PEX file | kolibri-0.17.0a0.dev0_git.51.gecde03b2.pex |
Windows Installer (EXE) | kolibri-0.17.0a0.dev0+git.51.gecde03b2-windows-setup-unsigned.exe |
Debian Package | kolibri_0.17.0a0.dev0+git.51.gecde03b2-0ubuntu1_all.deb |
Mac Installer (DMG) | kolibri-0.17.0a0.dev0+git.51.gecde03b2.dmg |
Android Package (APK) | kolibri-0.17.0a0.dev0+git.51.gecde03b2-0.1.4-debug.apk |
TAR file | kolibri-0.17.0a0.dev0+git.51.gecde03b2.tar.gz |
WHL file | kolibri-0.17.0a0.dev0+git.51.gecde03b2-py2.py3-none-any.whl |
Summary
Fixes error from #9698 where the CLI calling the linting function was not properly reading the return code, so was always returning a falsy value even when there were linting errors, meaning that the exit code was always 0.
References
Root cause of the missed linting here: #12428
Reviewer guidance
Deliberately introduce a linting error. Run
yarn run lint-frontend
. Ensure that the exit code is 1.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)