search

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
802 stars 665 forks source link

Remove FocusTrap in favor of KFocusTrap #12588

Closed MisRob closed 3 days ago

MisRob commented 2 months ago

🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.

Blocked by

Summary

As soon as Kolibri Design System contains https://github.com/learningequality/kolibri-design-system/issues/746, here in Kolibri we need to

(1) Remove all FocusTraps that are wrapping KModal s

<FocusTrap>
  <KModal>

(because KModal will contain the focus trapping logic within itself)

(2) Rename all remaining instances of FocusTrap to KFocusTrap

(3) Finally remove kolibri/core/assets/src/views/FocusTrap.vue

Comments

This may slightly conflict with https://github.com/learningequality/kolibri/issues/5488. Nothing really blocking, let’s just inform @rtibbles about progress on this issue.

Acceptance criteria

DakshArora1004 commented 2 months ago

Hi @MisRob, I'm interested in working on this issue after kolibri-design-system#746 is resolved. Could you assign it to me? I'll start preparing and will be ready to implement once the blocker is cleared.

MisRob commented 2 months ago

Hi @DakshArora1004, thanks for volunteering. I will assign you. After https://github.com/learningequality/kolibri-design-system/pull/764 is merged, you can use devserver-with-kds command to run Kolibri with your local Kolibri Design System. Feel free to ask any questions here.

MisRob commented 2 months ago

@DakshArora1004 I wanted to flag there's a possibility that this work will be addressed in the scope of https://github.com/learningequality/kolibri-design-system/pull/764#issuecomment-2326064319. Better to wait before working on what's the decision in the linked pull request.

MisRob commented 2 months ago

@DakshArora1004 I'm sorry for confusion but we will assign this to the same volunteer who has just resolved https://github.com/learningequality/kolibri-design-system/pull/764 since they will use this issue to ensure everything works as expected in Kolibri. Otherwise both of you would work on the same task.

There are other contributing opportunities in three repositories you're very welcome to explore. See the contributing guidelines including links to issues suitable for contribution for each repository here:

You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories.

lokesh-sagi125 commented 2 months ago

hey @MisRob .

MisRob commented 2 months ago

Hi, thanks @lokesh-sagi125, assigning as agreed

MisRob commented 2 months ago

@lokesh-sagi125 may be handy https://kolibri-dev.readthedocs.io/en/develop/howtos/development_with_kds.html ;) cc @akolson

MisRob commented 1 month ago

Hi @lokesh-sagi125, are you working on this or planning to? Just to know if we should keep the assignment or not.

lokesh-sagi125 commented 1 month ago

YES @MisRob i am still working on this issue, i was learning going through the codebase to avoid making errors while creating the component, i will raise a PR in 3 days

MisRob commented 1 month ago

Thanks for update @lokesh-sagi125. No problem and no pressure at all, just my regular rounds checking on possibly stale assignments.

rtibbles commented 3 days ago

Fixed in #12718

Thanks for your work here @lokesh-sagi125, very much appreciated!

lokesh-sagi125 commented 3 days ago

@rtibbles thank you for helping me with the rebasing issues . i hope to produce PR's with lesser problems in the future :).