learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
780 stars 648 forks source link

Investigate validations for username strings #12647

Open marcellamaki opened 3 weeks ago

marcellamaki commented 3 weeks ago

Observed behavior

Reported from Lewa in Clearinghouse: some users have names that have apostrophes. Kolibri doesn't allow such characters in the username part.

Expected behavior

Apostrophes should be a permitted character within names unless there

User-facing consequences

Usernames do not align to users' actual names.

Steps to reproduce

Create a user name that contains an ' in Kolibri

jredrejo commented 3 weeks ago

I've never seen usernames like that. For the full name it makes sense, but for the username... I am not sure if that's a good idea. I can imagine also problems in our api with json objects containing the usename