Closed AllanOXDi closed 1 month ago
Asset type | Download link |
---|---|
PEX file | kolibri-0.17.3a0.dev0_git.42.g9b97919d.pex |
Windows Installer (EXE) | kolibri-0.17.3a0.dev0+git.42.g9b97919d-windows-setup-unsigned.exe |
Debian Package | kolibri_0.17.3a0.dev0+git.42.g9b97919d-0ubuntu1_all.deb |
Mac Installer (DMG) | kolibri-0.17.3a0.dev0+git.42.g9b97919d.dmg |
Android Package (APK) | kolibri-0.17.3a0.dev0+git.42.g9b97919d-0.1.4-debug.apk |
TAR file | kolibri-0.17.3a0.dev0+git.42.g9b97919d.tar.gz |
WHL file | kolibri-0.17.3a0.dev0+git.42.g9b97919d-py2.py3-none-any.whl |
Thanks @AlexVelezLl for the helpful notes on the KDS upgrade requirements to make those required changes clearer in terms of what needs to be added to make sure the KDS version works.
@AllanOXDi I also wanted to add, in regards to this point in the acceptance criteria
any places that use the theme token numerical values in kolibri (so, anything that aligns with the updates spec in https://github.com/learningequality/kolibri-design-system/issues/775) should be updated to use the correct value. So, themeTokens.primary does not need to be updated anywhere. But, if there is a place where themeTokens.v_1000 is used, that needs to be updated to themeTokens.v_500. Note: I have not proactively evaluated how many places will need to be updated. It may be a handful, it may be a lot!
"But, if there is a place where themeTokens.v_1000 is used, that needs to be updated to themeTokens.v_500" was just one example to illustrate that any situations where the numerical values is used does need to be updated, vs. themeTokens.primary
which does not. This will have to be updated for all of the numbers. I didn't write this in a clear way. The mapping that Alex linked above and in that linked issue in the acceptance criteria shows all of the values that have been updated. The current state of v0.17.x is in the image on the color with the hex code, and the new number that we need to replace it with is what is in the red. For the "Brand" colors 200 becomes 100, 400 becomes 200, etc. If you have more questions about how to interpret the spec, please let me know!
Summary
…
References
Closes #12735.
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)