Fix various bugs in the Bloom Player implementation

[rtibbles]

Summary

• Does small clean up of unneeded conditional logic in the bloom player vue component to allow bloomd files to be rendered
• Fixes previously unnoticed bug where URLs with spaces in them, or URI encoded URLs would not get properly replaced by kolibri-zip - adds regression tests to ensure behaviour
• Migrates all the bloom player specific code that handles mapping audio files into the bloom player code, use the extensibility of the kolibri-zip module to allow this.
• Move the HTML style attribute handling into the main kolibri-zip DOMMapper
• Also fix URL spaces in names and URI encoding issues for DOM parsing too
• Update the DOMMapper to handle URLs in inline <style> blocks
• Do a small refactor to make code more readable, and give slight performance improvement on small DOMs
• Use URLSearchParameters to handle passing options to the bloom player iframe
• Add more parameters to hide the internal toolbar (defer to our own toolbar)
• Update bloom player to the latest version from upstream
• Include a small styling patch to make the previous/next buttons smaller
• Add to hashi README to describe how to update the bloom-player

References

Fixes #12728 Fixes #12726 Fixes #12725 Fixes #12727

Reviewer guidance

Verify that bloom reader is:

• still functioning as expected
• bloomd files are now renderable
• the internal bloom player controls are hidden
• all images are properly displayed inside books (when compared with epubs)
• the previous/next buttons are now a more reasonable size when hovered.

---

Testing checklist

• [ ] Contributor has fully tested the PR manually
• [ ] If there are any front-end changes, before/after screenshots are included
• [ ] Critical user journeys are covered by Gherkin stories
• [ ] Critical and brittle code paths are covered by unit tests

PR process

• [ ] PR has the correct target branch and milestone
• [ ] PR has 'needs review' or 'work-in-progress' label
• [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
• [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions[bot]]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.18.0.dev0_git.20241108194343.pex
Windows Installer (EXE)	kolibri-0.18.0.dev0+git.20241108194343-windows-setup-unsigned.exe
Debian Package	kolibri_0.18.0.dev0+git.20241108194343-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.18.0.dev0+git.20241108194343.dmg
Android Package (APK)	kolibri-0.18.0.dev0+git.20241108194343-0.1.4-debug.apk
TAR file	kolibri-0.18.0.dev0+git.20241108194343.tar.gz
WHL file	kolibri-0.18.0.dev0+git.20241108194343-py2.py3-none-any.whl

[pcenov]

Hi @rtibbles, I confirm that .bloomd files are now renderable and I also confirm the rest of the bullet points in the reviewer guidance. Issues observed during this round of QA which can be reported separately:

1. Some files (both of .bloomd and .bloompub type) cannot be rendered in the player and I am seeing the following error in the console:

BloomRunner-859fb260cac123ba42b8.bundle.js:1 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'split')
    at BloomRunner-859fb260cac123ba42b8.bundle.js:1:4138
    at e.value (BloomRunner-859fb260cac123ba42b8.bundle.js:1:4247)
    at 627-8ce4f4671fde42067b92.bundle.js:1:11867
    at async Promise.all (learn/index 0)

Examples are篾匠 and 157 God Gives Solomon Wisdom which can be imported from the following channel: tonih-nabul

2. All bloompub files always start from the beginning, so the progress made by the learner is not being saved.
3. The resource completed modal is never shown but I do see the 'Completed' icon

https://github.com/user-attachments/assets/3b97fd2a-fec7-4311-b509-5ac8989efbd4

4. bloompub files with audio are shown with a huge play button so that the audio can be started but there's no option to stop it. See WEB Ivile nɛ Ɛcʉlʉ for that:

https://github.com/user-attachments/assets/04038d83-14de-4c17-af69-0b7d560d0255

5. Both arrows look as if they are disabled:

https://github.com/user-attachments/assets/d83df91e-c02d-462b-a1e9-a48d772e9eeb

[rtibbles]

I think I'll fix 1 and 3 in the course of this PR, and we can file the others as follow up. Thanks for the channel reference!

[rtibbles]

Oh, I am addressing 4, as that was actually caused in this PR, so I just need to slightly undo something I did earlier.

[rtibbles]

@pcenov 1, 3, and 4 should now be addressed.

2 is not implemented in the bloom player, so would require a fair amount of work to get that working. 5 is more tractable, but would need a small update in the player code.

[pcenov]

Hi @rtibbles I confirm that points 1, 3, and 4 are addressed now and there are no new issues observed. I have also filed follow-up issues for 2 and 5.

[rtibbles]

Thank you, @pcenov!