Final token updates - Githubissues

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education

https://learningequality.org/kolibri/

MIT License

814 stars 687 forks source link

Final token updates #12754

Closed marcellamaki closed 1 month ago

marcellamaki commented 1 month ago

Summary

Resolves 3 outstanding categories of issues from the KDS upgrade:

ensures the second package.json is up to date
reverts a few changes that were the wrong color, as they had inadvertently been updated twice (from 1100 -> 600, and then 600 -> 300)
Updates tokens in a handful of missed files

References

Please see the first PR and the follow up comments for more details https://github.com/learningequality/kolibri/pull/12742

Reviewer guidance

Manual checks to confirm all is well:

does everything build and run properly
check the KDateRange component. Are there any regressions? (This is what tipped me off to the second package.json needing updating.)
Check the "end quiz" button - is it the correct shade of red?
otherwise - any glaring regressions?

Testing checklist

[ ] Contributor has fully tested the PR manually
[ ] If there are any front-end changes, before/after screenshots are included
[ ] Critical user journeys are covered by Gherkin stories
[ ] Critical and brittle code paths are covered by unit tests

PR process

[ ] PR has the correct target branch and milestone
[ ] PR has 'needs review' or 'work-in-progress' label
[ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
[ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
[ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

github-actions[bot] commented 1 month ago

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.17.3a0.dev0_git.50.gd80ab6be.pex
Windows Installer (EXE)	kolibri-0.17.3a0.dev0+git.50.gd80ab6be-windows-setup-unsigned.exe
Debian Package	kolibri_0.17.3a0.dev0+git.50.gd80ab6be-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.17.3a0.dev0+git.50.gd80ab6be.dmg
Android Package (APK)	kolibri-0.17.3a0.dev0+git.50.gd80ab6be-0.1.4-debug.apk
TAR file	kolibri-0.17.3a0.dev0+git.50.gd80ab6be.tar.gz
WHL file	kolibri-0.17.3a0.dev0+git.50.gd80ab6be-py2.py3-none-any.whl