Fix on my own merge account KCheckbox issue

AlexVelezLl commented 4 weeks ago

Summary

Fix merge account KCheckbox issue

References

Closes #12758

Reviewer guidance

Follow instructions in #12758

Testing checklist

[ ] Contributor has fully tested the PR manually
[ ] If there are any front-end changes, before/after screenshots are included
[ ] Critical user journeys are covered by Gherkin stories
[ ] Critical and brittle code paths are covered by unit tests

PR process

[ ] PR has the correct target branch and milestone
[ ] PR has 'needs review' or 'work-in-progress' label
[ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
[ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
[ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

github-actions[bot] commented 4 weeks ago

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.17.3b0.dev0_git.2.g2d2b5607.pex
Windows Installer (EXE)	kolibri-0.17.3b0.dev0+git.2.g2d2b5607-windows-setup-unsigned.exe
Debian Package	kolibri_0.17.3b0.dev0+git.2.g2d2b5607-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.17.3b0.dev0+git.2.g2d2b5607.dmg
Android Package (APK)	kolibri-0.17.3b0.dev0+git.2.g2d2b5607-0.1.4-debug.apk
TAR file	kolibri-0.17.3b0.dev0+git.2.g2d2b5607.tar.gz
WHL file	kolibri-0.17.3b0.dev0+git.2.g2d2b5607-py2.py3-none-any.whl

radinamatic commented 4 weeks ago

Checkbox now has the checkmark! 👏🏽

This has nothing to do with the present PR, but why is the user redirected to Select/Change facility again after signing in with the new credentials after the merge (1:48 in the video below) ? 🫤

https://github.com/user-attachments/assets/1e598983-37a9-4e9f-92a0-b435813ea4ad

rtibbles commented 4 weeks ago

Hrm, not entirely clear why it's doing that, it doesn't seem like it's meant to! https://github.com/learningequality/kolibri/blob/3b49acb9f9f7105241c118f342fc54a880c4b3fe/kolibri/plugins/user_profile/assets/src/views/ChangeFacility/MergeFacility.vue#L285

rtibbles commented 4 weeks ago

Oh, it rather looks like the logging in as the new user is not happening properly, so instead, Kolibri thinks the user's authentication has timed out, and so they are redirected to the auth page (with the next redirect to send them back to where they were).

learningequality / kolibri