learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
814 stars 687 forks source link

Add learner_needs field to contentnode API #12763

Closed rtibbles closed 1 week ago

rtibbles commented 3 weeks ago

Summary

References

Fixes #12687 Fixes one of the flaky tests remaining in https://github.com/learningequality/kolibri/issues/8255

Reviewer guidance

Does the learner_needs field properly appear in both internal and public API endpoints now? Do the test changes make sense.


Testing checklist

PR process

Reviewer checklist

github-actions[bot] commented 3 weeks ago

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0.dev0_git.20241029195015.pex
Windows Installer (EXE) kolibri-0.18.0.dev0+git.20241029195015-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0.dev0+git.20241029195015-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0.dev0+git.20241029195015.dmg
Android Package (APK) kolibri-0.18.0.dev0+git.20241029195015-0.1.4-debug.apk
TAR file kolibri-0.18.0.dev0+git.20241029195015.tar.gz
WHL file kolibri-0.18.0.dev0+git.20241029195015-py2.py3-none-any.whl
rtibbles commented 1 week ago

I think what you're asking for (the positive case) is covered here: https://github.com/learningequality/kolibri/pull/12763/files#diff-1f9030c267d0588f9d761b21abb8e5f2095df45e6ae7e440d3011cd0d30b2a4aR339

When we run the test suite against the remote endpoint, the same assertions are run, so these assertions are asserting that the learner needs are being properly returned for both the internal and public APIs.