Coach main navigation refactor

[AlexVelezLl]

Summary

• Refactor of the main navigation of the coach plugin for class, plans, reports -> class, lessons, quizzes, learners, groups.
• Get rid of the old plan and reports main view folders and map all needed files to new main view folders: lesson, quizzes, learners, groups.
• Get rid of the old plan and reports routes and map them in lesson, quizzes, learners, groups route files.
• Unify LesonPageNames and PageNames, and refactor all places to use the PageNames constants rather than burned strings.
• Get rid of many unnecesary routes and components of the old reports tab.
• Propagate use of useRouteTerms route segment constants through all routes for consistency.
• Unified multiple duplicated components into LearnerQuizPage, ExerciseQuestionListPage and QuestionLearnersReport components.
• Fix side panel condition to create new lesson.

https://github.com/user-attachments/assets/805d43c7-82a4-4d78-9023-38d4a2a384b6

References

Closes #12729 and #12801

Reviewer guidance

For code review:

• Check that the new folders structure, file organization and further refactors make sense

For QA:

• Navigate through all coach pages, and notice that:
  • All pages work correctly
  • There is a proper navigation flow and matches the figma specs
  • The correct tab in the main nav is properly selected in all pages

Follow ups

• If the tabs overflow and the more button is shown, if you go to any tab in the more button you will need to select the class again, because the navigation in that part isnt forwarding the classId. This can be solved in a follow up issue.

Testing checklist

• [x] Contributor has fully tested the PR manually
• [x] If there are any front-end changes, before/after screenshots are included
• [ ] Critical user journeys are covered by Gherkin stories
• [ ] Critical and brittle code paths are covered by unit tests

PR process

• [x] PR has the correct target branch and milestone
• [x] PR has 'needs review' or 'work-in-progress' label
• [x] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
• [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions[bot]]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.18.0.dev0_git.20241111165948.pex
Windows Installer (EXE)	kolibri-0.18.0.dev0+git.20241111165948-windows-setup-unsigned.exe
Debian Package	kolibri_0.18.0.dev0+git.20241111165948-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.18.0.dev0+git.20241111165948.dmg
Android Package (APK)	kolibri-0.18.0.dev0+git.20241111165948-0.1.4-debug.apk
TAR file	kolibri-0.18.0.dev0+git.20241111165948.tar.gz
WHL file	kolibri-0.18.0.dev0+git.20241111165948-py2.py3-none-any.whl

[pcenov]

Hi @AlexVelezLl, I was able to identify the following issues, which I can also report separately if not in scope for this PR:

1. The tabs in the navigation should go to the second line when there isn't enough space, and only after that we should be showing the ... button. See the video:

https://github.com/user-attachments/assets/d324f647-e98b-4ed3-9397-85248fec9568

2. The 'Edit lesson' option actually creates a brand new lesson:

https://github.com/user-attachments/assets/28db4ea9-1ed6-49de-adb7-1b9b8a9ba2ac

3. Nothing happens when I click the 'Preview' button for a quiz:

https://github.com/user-attachments/assets/cc90784b-7c80-4dc6-8245-1c3ad5ab7e75

4. When I delete a quiz I am not immediately brought back to the Quizzes page:

https://github.com/user-attachments/assets/bd10fe47-99c1-4d54-84e0-5b6f24f6c01b

5. When I make a copy of a quiz and I click the 'All quizzes' link then I see an empty page:

https://github.com/user-attachments/assets/1ed3ff38-bcc0-4e49-bad4-03be1d7ec6b5

6. When there is only one class in the facility and I navigate from another plugin to a page in the Coach plugin, then I always see the Classes page before going to the desired page which should be avoided if possible. This is especially obvious in slow 3g network throttling:

https://github.com/user-attachments/assets/a45c163f-1e55-4382-b266-7f9f30879c09

[AlexVelezLl]

Thank you @pcenov!

1. Yes, I think we can add this as a follow up issue as this is an existing behaviour even in the current implementation.
2. I will fix this!
3. This is an issue from #12685. ~I think we could just hide this button for now~. I just linked the preview page!
4. Will fix this :)
5. ~Will fix this too~. This is also happening in develop so is a general bug when we copy a quiz and go back to the quizzes pages rather than a bug introduced in this PR. We can open another issue for this.
6. ~Is also possible to replicate this in the current version in develop? Or is something that has been introduced in this PR~. This is also happening in develop.

[AlexVelezLl]

I have fixed 2, 3 and 4 @pcenov :). 1, 5 and 6 are issues that also happen in develop so I think it will be better to have different issues for them.

[pcenov]

Thanks @AlexVelezLl - I confirm that 2, 3 and 4 are fixed now and I have filed follow-up issues for the rest.

While regression testing today I noticed the following issues, which again if not caused by changes made here, I'll report separately:

1. The Export as CSV button in Coach > Lessons is not working, seeing the following error in the console: TypeError: Cannot read properties of undefined (reading 'map'):

https://github.com/user-attachments/assets/0a1f497c-d47d-4650-9e6f-2c4f83ce3616

2. When creating/editing a quiz the icons are positioned right next to the 'Select all':

3. Attempting to view the Learners page as a Learner user results in seeing a blank page, instead of seeing the message "You must be signed in as an admin or coach to view this page":

[AlexVelezLl]

Thank you @pcenov! I have fixed numbers 1 and 2. Number 1 was also happening in develop but just fixed this as this was a quick fix.

Number 3 is part of a broader issue which is that in coach we dont have a not found or permissions error page in general, not as part of this PR, so I think this could be reported separately.

[pcenov]

Thanks @AlexVelezLl - I've verified that points 1 and 2 are fixed now and I didn't see any other issues while regression testing. I've reported separately the permissions issue.