learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
811 stars 685 forks source link

Bloom player - The player's previous and next arrows look disabled #12779

Open pcenov opened 2 weeks ago

pcenov commented 2 weeks ago

Observed behavior

This is a minor follow-up to https://github.com/learningequality/kolibri/pull/12752:

The player's previous and next arrows look as if they are disabled because of the opacity of the color:

https://github.com/user-attachments/assets/d83df91e-c02d-462b-a1e9-a48d772e9eeb

Expected behavior

If possible the buttons should be more pronounced.

Steps to reproduce the issue

  1. Install the build from https://github.com/learningequality/kolibri/pull/12752
  2. Import bloompub resources from the following channel: tonih-nabul
  3. Start interacting with a bloompub resource and observe the color of the buttons

Usage Details

Windows 11, Ubuntu 22 - Chrome

pcenov commented 2 weeks ago

@radinamatic

radinamatic commented 2 weeks ago

Milestone is tentative.

mikeybac commented 1 week ago

Hi, could I get assigned to this task? Tysm!

rtibbles commented 1 week ago

Hi @mikeybac - this isn't quite ready to be worked on yet, as it will need this PR to be merged first: https://github.com/learningequality/kolibri/pull/12752 - as long as you're happy to wait for that, I can assign you.

The other thing to note, is that this is most likely going to need to be fixed not in Kolibri itself, but in the fork of the Bloom Player library that we maintain.

Familiarising yourself with that repository is probably the first step: https://github.com/learningequality/bloom-player

Instructions on how to use updated code from that repository in Kolibri are in the README updates in the above PR #12752

mikeybac commented 1 week ago

No worries, how long will the PR take to be merged?

rtibbles commented 1 week ago

It should be merged early next week!

mikeybac commented 1 week ago

Sounds great, can I be assigned? I'm fine with waiting.

rtibbles commented 1 week ago

Sure thing, I've assigned you - please feel free to ask any questions as you're looking through the code!