When running under the Kolibri process bus, use a logging queue to prevent reentrant logging errors and file contention - Githubissues

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education

https://learningequality.org/kolibri/

MIT License

811 stars 685 forks source link

When running under the Kolibri process bus, use a logging queue to prevent reentrant logging errors and file contention #12785

Closed rtibbles closed 1 week ago

rtibbles commented 2 weeks ago

Summary

Patches all logger handlers at process bus startup to use a logging queue handler instead of their regular handlers
Create a queue listener defer all logging to a single thread
Conditionalize the queue to be either single or multi process depending on whether we are using multiprocessing for our task runner or not

References

Fixes #8376

May also help with our persistent logging errors seen on Windows platforms (but not tested, and not guaranteed).

Reviewer guidance

…

Testing checklist

[ ] Contributor has fully tested the PR manually
[ ] If there are any front-end changes, before/after screenshots are included
[ ] Critical user journeys are covered by Gherkin stories
[ ] Critical and brittle code paths are covered by unit tests

PR process

[ ] PR has the correct target branch and milestone
[ ] PR has 'needs review' or 'work-in-progress' label
[ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
[ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
[ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

github-actions[bot] commented 2 weeks ago

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.18.0.dev0_git.20241104184852.pex
Windows Installer (EXE)	kolibri-0.18.0.dev0+git.20241104184852-windows-setup-unsigned.exe
Debian Package	kolibri_0.18.0.dev0+git.20241104184852-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.18.0.dev0+git.20241104184852.dmg
Android Package (APK)	kolibri-0.18.0.dev0+git.20241104184852-0.1.4-debug.apk
TAR file	kolibri-0.18.0.dev0+git.20241104184852.tar.gz
WHL file	kolibri-0.18.0.dev0+git.20241104184852-py2.py3-none-any.whl