learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
811 stars 684 forks source link

Ensure session and summary log outputs are consistent between channel and displayed node #12804

Open rtibbles opened 2 weeks ago

rtibbles commented 2 weeks ago

Summary

References

Fixes #12791

Reviewer guidance

Engage with resources that are in multiple channels (e.g. some KA exercises for different languages, and those that have been copied into the Kolibri QA channel).

Export the session and summary logs.

Make sure that the topic tree hierarchy and the channel name match up to each other in the logs.


Testing checklist

PR process

Reviewer checklist

github-actions[bot] commented 2 weeks ago

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0.dev0_git.20241119230723.pex
Windows Installer (EXE) kolibri-0.18.0.dev0+git.20241119230723-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0.dev0+git.20241119230723-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0.dev0+git.20241119230723.dmg
Android Package (APK) kolibri-0.18.0.dev0+git.20241119230723-0.1.4-debug.apk
TAR file kolibri-0.18.0.dev0+git.20241119230723.tar.gz
WHL file kolibri-0.18.0.dev0+git.20241119230723-py2.py3-none-any.whl
pcenov commented 3 days ago

Hi @rtibbles - I noticed the following issues while manually testing:

  1. In both logs there's always an empty 'Topic level N' column before the 'Content id' column:

empty level

  1. In the summary logs I can see the following issue, where the entries from topic level 4 to 9 are incorrect for a resource imported from KA Chinese:

summary logs

Test channel token which you can use to replicate the issue: milas-tarol Logs and DB in google drive: https://drive.google.com/drive/u/0/folders/17KajXswJjetgPzTTv0bdHrWNGPyg-5N5

rtibbles commented 2 days ago

Thanks @pcenov - I have fixed the first issue - I had originally left the second as intended behaviour because of the subtly different way we track data for summary logs vs session logs, but I am inspecting the session logs to get the data we need to ensure consistent behaviour between the two now.