Open rtibbles opened 2 weeks ago
Asset type | Download link |
---|---|
PEX file | kolibri-0.18.0.dev0_git.20241107000752.pex |
Windows Installer (EXE) | kolibri-0.18.0.dev0+git.20241107000752-windows-setup-unsigned.exe |
Debian Package | kolibri_0.18.0.dev0+git.20241107000752-0ubuntu1_all.deb |
Mac Installer (DMG) | kolibri-0.18.0.dev0+git.20241107000752.dmg |
Android Package (APK) | kolibri-0.18.0.dev0+git.20241107000752-0.1.4-debug.apk |
TAR file | kolibri-0.18.0.dev0+git.20241107000752.tar.gz |
WHL file | kolibri-0.18.0.dev0+git.20241107000752-py2.py3-none-any.whl |
Hi @rtibbles,
I noticed the following issues:
https://github.com/user-attachments/assets/b7bcb117-fbfd-48c9-bee4-5874028101d7
And 'Unidad 1 - Herramientas para el empoderamiento' from the QA channel, where the player buttons are missing:
I've created the following test channel zapif-babuz
using the provided example resources at https://h5p.org/content-types-and-applications so that you can have a look and replicate the issues.
Thanks @pcenov - I guess there was a good reason I marked this as a draft!
Summary
References
Fixes #9761
Reviewer guidance
Does this work for H5P files that contain large media assets like videos and audio?
Questions - this covers the previously encountered case where H5P files contained incredibly large individual files, but doesn't cover the case where the archive files themselves are just enormous, but contain lots of tiny files. Have we encountered any archives where this may be the issue? Is there any benefit to limiting the size of segments and lazily loading them on demand? These may be empirical questions best answered by looking at lots of H5P files.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)