learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
814 stars 686 forks source link

Handle frontend loaded zip archive content (h5p, bloomd) that contains large files #12805

Open rtibbles opened 2 weeks ago

rtibbles commented 2 weeks ago

Summary

References

Fixes #9761

Reviewer guidance

Does this work for H5P files that contain large media assets like videos and audio?

Questions - this covers the previously encountered case where H5P files contained incredibly large individual files, but doesn't cover the case where the archive files themselves are just enormous, but contain lots of tiny files. Have we encountered any archives where this may be the issue? Is there any benefit to limiting the size of segments and lazily loading them on demand? These may be empirical questions best answered by looking at lots of H5P files.


Testing checklist

PR process

Reviewer checklist

github-actions[bot] commented 2 weeks ago

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0.dev0_git.20241107000752.pex
Windows Installer (EXE) kolibri-0.18.0.dev0+git.20241107000752-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0.dev0+git.20241107000752-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0.dev0+git.20241107000752.dmg
Android Package (APK) kolibri-0.18.0.dev0+git.20241107000752-0.1.4-debug.apk
TAR file kolibri-0.18.0.dev0+git.20241107000752.tar.gz
WHL file kolibri-0.18.0.dev0+git.20241107000752-py2.py3-none-any.whl
pcenov commented 1 week ago

Hi @rtibbles,

I noticed the following issues:

  1. A lot of resources are not loading at all. Examples are 'Advent Calendar (beta)', 'Interactive book', 'Course Presentation', 'Virtual Tour (360)'. For others it takes noticeably longer to load.

https://github.com/user-attachments/assets/b7bcb117-fbfd-48c9-bee4-5874028101d7

  1. In some resources there are missing icons, examples are 'Speak the Words Set':

speak

And 'Unidad 1 - Herramientas para el empoderamiento' from the QA channel, where the player buttons are missing:

buttons

I've created the following test channel zapif-babuz using the provided example resources at https://h5p.org/content-types-and-applications so that you can have a look and replicate the issues.

rtibbles commented 1 week ago

Thanks @pcenov - I guess there was a good reason I marked this as a draft!