Ensure Consistent 400 Response for Invalid Input in Kolibri Public Content APIs with Studio

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education

https://learningequality.org/kolibri/

MIT License

814 stars 686 forks source link

Ensure Consistent 400 Response for Invalid Input in Kolibri Public Content APIs with Studio #12807

Open ozer550 opened 2 weeks ago

ozer550 commented 2 weeks ago

Description

Currently, the Kolibri public content APIs, specifically retrieve function of ContentNodeTreeViewset and ImportMetadataViewset handle invalid input by returning a 404 response. To ensure consistent API behavior across Kolibri and Studio, we need to update these views to handle invalid input in a way that aligns with the implementation in Studio.

Tasks:

[ ] Update the retrieve function of ContentNodeTreeViewset and ImportMetadataViewset to return 400 when there is a bad input.
[ ] Update test for TreeViewset.
[ ] Write new test to ensure the same for ImportMetadataViewset.

Expected Outcome:

Consistency in behavior across APIs.

References:

We would want to refactor similar to this PR.

manzil-infinity180 commented 2 weeks ago

can I take this issue?

AllanOXDi commented 2 weeks ago

Hi @manzil-infinity180, Sure you can! I have assigned it to you. Thanks for contributing

ozer550 commented 2 weeks ago

Feel free to ask any questions you have on the way @manzil-infinity180 :)

rajRishi22 commented 2 weeks ago

Sir , I know that this issue has already been assign but can i work together to solve this problem ?

manzil-infinity180 commented 2 weeks ago

Hello @rajRishi22 , I have already solved this issue I will raise pr in some following day. You can take a look at some other issues with no assignee Thank you

rajRishi22 commented 2 weeks ago

Hello @manzil-infinity180 , I will look into other issues.

qmhqmhqmhqmh commented 1 week ago

can I take this issue?

MisRob commented 1 week ago

Hi @qmhqmhqmhqmh, thanks for volunteering! It's best to always preview whether an issue has an assignee or no. This one is already taken and even has a pull request linked.

There are other contributing opportunities in several repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:

You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories.