learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
811 stars 684 forks source link

Remove "Activity" tab from learner view #12816

Open AllanOXDi opened 1 week ago

AllanOXDi commented 1 week ago

Summary

This PR Remove "Activity" tab from learner view

The currently on develop

image

After the clean up .

on this PR

https://github.com/user-attachments/assets/1837f2bf-8ea1-4798-ae97-209bf4958fc9

On figma

image

References

Closes #12733

Reviewer guidance

Testing checklist

PR process

Reviewer checklist

github-actions[bot] commented 1 week ago

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0.dev0_git.20241120075126.pex
Windows Installer (EXE) kolibri-0.18.0.dev0+git.20241120075126-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0.dev0+git.20241120075126-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0.dev0+git.20241120075126.dmg
Android Package (APK) kolibri-0.18.0.dev0+git.20241120075126-0.1.4-debug.apk
TAR file kolibri-0.18.0.dev0+git.20241120075126.tar.gz
WHL file kolibri-0.18.0.dev0+git.20241120075126-py2.py3-none-any.whl
radinamatic commented 2 days ago

@AllanOXDi There seem to be a conflict which prevented the build of the artifacts after the last change, could you check it out? 🙏🏽

AllanOXDi commented 2 days ago

Fixed!

radinamatic commented 20 hours ago
  1. Confirm that Tabs are no longer in use and all related code is cleaned up. ✔️
  2. Verify that ActivityList is no longer rendered on this page (but remains in kolibri-common). - not sure if this can be confirmed in the UI only
  3. For both lessons and quizzes, only the first 10 items are displayed initially. ✔️
  4. When there are more than 10 items, a "view more" button appears. ✔️
  5. On clicking "view more," an additional 10 items are displayed. ✔️
  6. Ensure all spacing and layout match the Figma design ✔️
  7. Confirm that there are no regressions affecting existing functionality. ❗

    a) Export CSV button is not working, absolutely nothing happens when clicked.

    b) My learner did complete an exercise, but it's not recorded/displayed in the summary:

    2024-11-21_18-17-53