learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education

https://learningequality.org/kolibri/

MIT License

811 stars 684 forks source link

Replace unwrapped "up" and "down" strings used for aria labeling #12817

Open AllanOXDi opened 1 week ago

AllanOXDi commented 1 week ago

Summary

This PR audits and replaces unwrapped "up" and "down" strings used for aria labeling

References

12392

Reviewer guidance.

review the slack conversation here for more context

Testing checklist

[ ] Contributor has fully tested the PR manually
[ ] If there are any front-end changes, before/after screenshots are included
[ ] Critical user journeys are covered by Gherkin stories
[ ] Critical and brittle code paths are covered by unit tests

PR process

[ ] PR has the correct target branch and milestone
[ ] PR has 'needs review' or 'work-in-progress' label
[ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
[ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
[ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

github-actions[bot] commented 1 week ago

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.18.0.dev0_git.20241121134752.pex
Windows Installer (EXE)	kolibri-0.18.0.dev0+git.20241121134752-windows-setup-unsigned.exe
Debian Package	kolibri_0.18.0.dev0+git.20241121134752-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.18.0.dev0+git.20241121134752.dmg
Android Package (APK)	kolibri-0.18.0.dev0+git.20241121134752-0.1.4-debug.apk
TAR file	kolibri-0.18.0.dev0+git.20241121134752.tar.gz
WHL file	kolibri-0.18.0.dev0+git.20241121134752-py2.py3-none-any.whl