learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
811 stars 684 forks source link

Resolve issue with user not seeing updated practice quiz score on TopicsContentPage #12823

Closed LianaHarris360 closed 1 week ago

LianaHarris360 commented 1 week ago

Summary

This pull request updates the function setContentNodeProgress() if statement to use the greater than or equal to (>=) operator to allow the user to see the latest practicer quiz score after clicking the back button on the ContentPage.

Previously, if the progress value passed to setContentNodeProgress() equaled 1 and the progress in the contentNodeProgressMap also equaled 1, the function wouldn't update either the contentNodeProgressMap or the contentNodeProgressMetaDataMap, until the page was reloaded.

Before:

https://github.com/user-attachments/assets/d663cb0b-9cdb-4fdf-b411-2d792589918f

After:

https://github.com/user-attachments/assets/c2173d11-f019-43a7-8c25-9773b4054be6

References

Fixes #12663

Reviewer guidance

  1. Import a practice quiz resource from Kolibri QA Channel > Exercises > Practice quizzes.
  2. Navigate to the practice quizzes Topics Page and take a practice quiz.
  3. Click the "Back" arrow on the TopicsContentPage.

Testing checklist

PR process

Reviewer checklist

github-actions[bot] commented 1 week ago

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0.dev0_git.20241112204553.pex
Windows Installer (EXE) kolibri-0.18.0.dev0+git.20241112204553-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0.dev0+git.20241112204553-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0.dev0+git.20241112204553.dmg
Android Package (APK) kolibri-0.18.0.dev0+git.20241112204553-0.1.4-debug.apk
TAR file kolibri-0.18.0.dev0+git.20241112204553.tar.gz
WHL file kolibri-0.18.0.dev0+git.20241112204553-py2.py3-none-any.whl