search

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
810 stars 684 forks source link

[DO NOT MERGE, FOR QA ONLY] Test KDropdownMenu Keyboard Navigation #12838

Closed AlexVelezLl closed 2 days ago

AlexVelezLl commented 1 week ago

Summary

https://github.com/learningequality/kolibri-design-system/pull/818 Introduces some fixes regarding Keyboard Navigation in KDropdownMenu. This PR introduces these changes in Kolibri for QA to test that this is the expected behaviour.

Reviewer guidance

Look for dropdown menus, and test its behaviour using Keyboard Navigation.

AlexVelezLl commented 1 week ago

@radinamatic could you please take a look and confirm if this is the expected behaviour while keyboard navigating dropdown menus? :)

github-actions[bot] commented 1 week ago

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0.dev0_git.20241113145120.pex
Windows Installer (EXE) kolibri-0.18.0.dev0+git.20241113145120-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0.dev0+git.20241113145120-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0.dev0+git.20241113145120.dmg
Android Package (APK) kolibri-0.18.0.dev0+git.20241113145120-0.1.4-debug.apk
TAR file kolibri-0.18.0.dev0+git.20241113145120.tar.gz
WHL file kolibri-0.18.0.dev0+git.20241113145120-py2.py3-none-any.whl
radinamatic commented 1 week ago

@AlexVelezLl While testing the keyboard navigation ONLY I did not find any issues, and the dropdown element Options in Device > Channels, and New quiz in Coach > Plan > Quizzes behaved as expected and required.

However, after I tried to confirm the results with the screenreader, my NVDA was not giving the expected output 😕

What we call dropdown is essentially the Menu button pattern from ARIA Authoring Practices Guide (APG). Looking at the page source after I installed the asset on Windows 10, while the proper roles menu and menu-item seem to be applied, the required aria-haspopup property, and the aria-expanded state are not.

Could we fix these property & states issues before merging the PR?

AlexVelezLl commented 6 days ago

Hi @radinamatic, I foresee that including these property & states will need more changes and considerations. And as for now the issue was about fixing the "keyboard navigation", this is a little bit out of scope (and also because this is an existing behaviour rather than a regression introduced in the PR). I will open a follow up issue to make sure we include this too :). Is it okay? :open_hands:

AlexVelezLl commented 2 days ago

Follow up issue for this: https://github.com/learningequality/kolibri-design-system/issues/832