Remove channel labels from non-public ContentNode API

Pulkitxm commented 1 week ago

Fixes

Closes #12842

Summary

Removed the channel labels from the non-public ContentNodeViewset API.
Added a flag use_deprecated_channels_labels to the OptionalContentNodePagination class to handle the inclusion of channel labels.
Ensured that the public API still provides the channel labels.
Verified that older Kolibri versions can navigate and search the library remotely without issues.

References

Issue: Remove the channel labels from the non-public ContentNode API
Related PR: Update SearchFiltersPanel for Coach

Reviewer guidance

Test the non-public ContentNodeViewset API to ensure that channel labels are no longer returned.
Verify that the public API still provides the channel labels.
Ensure that older Kolibri versions (0.17.x) can navigate and search the library remotely from Kolibri 0.18.x and filter by Channels.
Check for any potential issues or regressions in the search functionality and filtering by channels.

Testing checklist

[x] Contributor has fully tested the PR manually
[x] If there are any front-end changes, before/after screenshots are included
[x] Critical user journeys are covered by Gherkin stories
[x] Critical and brittle code paths are covered by unit tests

PR process

[X] PR has the correct target branch and milestone
[X] PR has 'needs review' or 'work-in-progress' label
[X] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
[X] If this is an important user-facing change, PR or related issue has a 'changelog' label
[X] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

MisRob commented 1 week ago

Hi @Pulkitxm, welcome and thanks for your effort.

@nucleogenesis would you please have a look and decide whether we should review and if so, if the changes make sense?

@Pulkitxm Looking at https://github.com/learningequality/kolibri/issues/12842 it wasn't originally indicated as open for contributions. I wanted to provide some guidance so next time you can contribute successfully. Please find an unassigned 'help wanted' issue and before working on it, message us there and wait for an assignment. It's best to familiarize yourself with the contributing guidelines:

Then you can see the list of unassigned "help wanted" or "good first issue" issues across all repositories.

github-actions[bot] commented 1 week ago

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.18.0.dev0_git.20241114073439.pex
Windows Installer (EXE)	kolibri-0.18.0.dev0+git.20241114073439-windows-setup-unsigned.exe
Debian Package	kolibri_0.18.0.dev0+git.20241114073439-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.18.0.dev0+git.20241114073439.dmg
Android Package (APK)	kolibri-0.18.0.dev0+git.20241114073439-0.1.4-debug.apk
TAR file	kolibri-0.18.0.dev0+git.20241114073439.tar.gz
WHL file	kolibri-0.18.0.dev0+git.20241114073439-py2.py3-none-any.whl

rtibbles commented 2 days ago

Hi @Pulkitxm - any further guidance needed here? Feel free to ask any follow up questions!

learningequality / kolibri