search

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
820 stars 699 forks source link

Setup Wizard - 'Responsibilities of administrator' is shown twice when importing from a device with multiple facilities #12894

Open pcenov opened 1 week ago

pcenov commented 1 week ago

Observed behavior

The 'Responsibilities of administrator' page is shown twice when importing from a device with one or multiple facilities:

https://github.com/user-attachments/assets/c2b39ded-c5c3-4f4f-9c18-5a5861d6fb10

The issue is extant in both 0.17.3 and 0.18.

Expected behavior

The 'Responsibilities of administrator' page should be displayed only once.

Steps to reproduce the issue

  1. Install the build asset from https://github.com/learningequality/kolibri/pull/12893 on one device.
  2. Install it on another device.
  3. On the first device setup a device with one or multiple facilities
  4. On the second device go through the 'Import all data from an existing learning facility' flow.

Logs

logs.zip

Usage Details

Kolibri 0.17.3 and 0.18 Ubuntu 22 - Chrome

pcenov commented 1 week ago

@radinamatic

MisRob commented 6 days ago

Here's a guide on Running another Kolibri instance alongside the development server

Jeevansm25 commented 5 days ago

Can I take this issue?

AlexVelezLl commented 5 days ago

Hi @Jeevansm25! For sure! I will assign this issue to you. Please be aware that this issue is in our setup_wizard plugin. To reproduce this issue you need to have a fresh start of Kolibri so you will need to create new folders and override your KOLIBRI_HOME, or remove your default KOLIBRI_HOME folder each time you finished the setup and want to reproduce it again. To have another Kolibri instance running for the import step you can check MisRob's comment. Let us know if you have any questions.

Jeevansm25 commented 4 days ago

I have identified the issue and corrected the code. Now, I would like to test the changes. Previously, before correcting the code, I downloaded the .pex file from the workflow. Could you guide me on how to test the updated code?

On Tue, Dec 3, 2024 at 4:24 PM Alex Velez @.***> wrote:

Assigned #12894 https://github.com/learningequality/kolibri/issues/12894 to @Jeevansm25 https://github.com/Jeevansm25.

— Reply to this email directly, view it on GitHub https://github.com/learningequality/kolibri/issues/12894#event-15507617261, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7BGIILW6YCTFGZXD5MLBAD2DWEV5AVCNFSM6AAAAABSVKBLOKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGUYDONRRG4ZDMMI . You are receiving this because you were assigned.Message ID: @.***>

MisRob commented 4 days ago

Hi @Jeevansm25, if you follow the guide I posted on running the two instances, one of them is a development server. Open Kolibri from its URL and it should have your latest local updates.

You can consider the other .pex instance just for having the other facility available - generally it shouldn't be problem for it to run on the older version. Let us know if this work, and if not, please post more details on what exactly you're doing.

Jeevansm25 commented 2 days ago

Hi @Jeevansm25, if you follow the guide I posted on running the two instances, one of them is a development server. Open Kolibri from its URL and it should have your latest local updates.

You can consider the other .pex instance just for having the other facility available - generally it shouldn't be problem for it to run on the older version. Let us know if this work, and if not, please post more details on what exactly you're doing.

After making the changes in the code, do we need to build the project first and then run the Kolibri instances, or can we directly run the instances to see the updates reflected?

Looking forward to your clarification.

MisRob commented 2 days ago

@Jeevansm25 if you follow the guide step by step and get to "Run your development server", then upon running yarn run devserver or yarn run devserver-hot, you only need to update code and you should see the updates reflected without the need to rebuild the .pex or rerun the development server.

MisRob commented 2 days ago

@Jeevansm25 if you haven't yet done so, set up your development server https://kolibri-dev.readthedocs.io/en/develop/getting_started.html#getting-started

Jeevansm25 commented 10 hours ago

@Jeevansm25 if you haven't yet done so, set up your development server https://kolibri-dev.readthedocs.io/en/develop/getting_started.html#getting-started

Of course, I followed all these steps, but I didn't see the changes I made on the development server reflected in the instance running through the .pex file. Could you please clarify this step for me?