search

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
805 stars 672 forks source link

Unidentified "undefined" string inside Perseus #1811

Closed radinamatic closed 7 years ago

radinamatic commented 7 years ago

Summary

String undefined appears on the side or below the exercise, inside the Perseus renderer, below problem-area and above the hintsarea... :thinking:

System information

Screenshots

ubuntu3 start running - oracle vm virtualbox_331

win10 start running - oracle vm virtualbox_319

rtibbles commented 7 years ago

Hrm, this appears to be a vue js issue that should have been fixed in 2.0.4 according to this commit: https://github.com/vuejs/vue/commit/d0afcd3cf9ad572621676ef02005d226cb4ac7c4 investigating further to see why it might be recurring here.

rtibbles commented 7 years ago

This seems to be precisely this issue: https://github.com/vuejs/vue/issues/4107, not sure why we are getting it when we are using vuejs 2.3.3.

radinamatic commented 7 years ago

Whatever that was, it's gone in the latest 0.5.0 build (1673), and the hint button is showing correctly :+1:

win10 start running - oracle vm virtualbox_332

ubuntu3 start running - oracle vm virtualbox_333

Closing this for now, unless @rtibbles wants to chase the elusive undefined down the rabbit hole... :wink:

radinamatic commented 7 years ago

Resurfaced on PEX build from #1816, it is unclear to me which conditions make the Hint button not showing correctly... :disappointed:

It appears on both device owner or a learner, independent of whether I start the PEX with Pyton 2 or 3, no errors whatsoever in the console or the Terminal... Will test on Windows next.

ubuntu3 start running - oracle vm virtualbox_342

Anything specific to look for @rtibbles?

radinamatic commented 7 years ago

Present on Windows 7 too, on EXE build from #1816, no idea if the "undefined" on the right has anything to do with "undefined" on the left... :confused:

win7 start running - oracle vm virtualbox_344

rtibbles commented 7 years ago

Is this always in a vm, @radina? Thinking that it is due to a race condition that applies due to resource constraints. Will try replicating on a more resource constrained system.

radinamatic commented 7 years ago

@rtibbles No, it was reported during the RTL hack session, and you can see it on KA Early Math exercises on the demo server:

https://kolibridemo.learningequality.org/learn/#/1ceff53605e55bef987d88e0908658c5/topics/c/69e5e6abf479581483d441b83d7d76f4

rtibbles commented 7 years ago

I can reproduce this on demo servers, but not locally, either in production or development mode.

rtibbles commented 7 years ago

Nor in either dev or production on browserstack...

rtibbles commented 7 years ago

This should be fixed.

radinamatic commented 7 years ago

Haven't seen it in on the latest versions, will report back if I stumble upon again!

rtibbles commented 7 years ago

That's because I fixed it, of course!

radinamatic commented 7 years ago

Of course, wouldn't dream of diminishing your merit! :blush: :+1: