learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
793 stars 656 forks source link

implement 'user display' component for conveying name, username, role, and other information consistently #5024

Open indirectlylit opened 5 years ago

indirectlylit commented 5 years ago

Observed behavior

In a coach report, these are two different users:

image

In facility users we show:

image

In class management we show:

image

related clearinghouse issues:

Expected behavior

Recommend we come up with a consistent, single-column representation of a user that can be used in all tables. This block would contain:

It would be responsive to the available space and to the lengths of the values. It could optionally leverage tooltips or advanced ellipsis behaviors to deal with small screens and long names.

As one possible example, we might try something like:

image

User-facing consequences

Hard to scan and differentiate users

Context

0.12.0 beta 4

khangmach commented 5 years ago

I like this a lot and am on board with placing username under fullname as opposed to its own column. Helps make a clear differentiation between name and the more abstract and fluid username.

However, in your implementation above I think it's much more difficult to:

I would advocate for placing the role label in its own column, where username was previously

indirectlylit commented 5 years ago

yeah makes sense. another dimension to possibly play with is the icon... we do this in facility class management:

image

and we do this in device permission management:

image

so maybe there's some kind of consistent role-based iconography we could establish that would negate the need for an additional column

khangmach commented 5 years ago

example

table

khangmach commented 5 years ago

maybe there's some kind of consistent role-based iconography we could establish that would negate the need for an additional column

Yeah, it's a bit of a tricky problem because we strictly use google material icons, but I don't see much issue in swapping a user icon for a key/coach icon. We still convey the concept of "what is a user, and what info is associated with a user" very clearly (albeit repetitively) through tables throughout the app anyways.

indirectlylit commented 5 years ago

just an idea:

image

khangmach commented 5 years ago

that works to me 👀 thoughts @jtamiace ?

jtamiace commented 5 years ago

Works for me too. We'll just need to find an icon for class coach with this approach (could be an unfilled version of the one above?), and facility admin (and class admin down the line if that's ever a thing)

indirectlylit commented 5 years ago

We'll still need to put a little more thought into a couple things about context... e.g.:

khangmach commented 5 years ago

slice

Some solutions based on our discussions over slack. Suggested high level improvements:

indirectlylit commented 5 years ago

this looks great - nice job!

minor clarification: I assume in the table on the right, all "Super admin" users should have gold keys?

khangmach commented 5 years ago

@indirectlylit whoops yes. Adjusted the original image