search

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
818 stars 694 forks source link

Some group-scoped report activity looks missing (when filters are applied) #6569

Open lyw07 opened 4 years ago

lyw07 commented 4 years ago

Observed behavior

reported by @jeepurs during 0.13.1 beta bug bash, described here: https://www.notion.so/learningequality/Missing-group-scoped-report-activity-7ff4bc2193834221a0092d11e2944c9a

The activity lizdemo started 'Copy of Test is missing: Screenshot_from_2020-02-14_101616

Expected behavior

all the group activities should be available

User-facing consequences

coaches don't get to see all the activities

Errors and logs

Steps to reproduce

  1. create two learners account and put them into a group
  2. log in as learner 1, do some activity
  3. log in as learner 2, do some activity
  4. log in as a coach, check the activity feed for the group defined earlier

Context

Kolibri version: 0.13.1 beta2

jonboiser commented 4 years ago

I think the missing notification "lizdemo started..." is on the page now (link), but it's hidden until I click "Show more". Not sure why it's filtered out when it's only the fourth notification.

lyw07 commented 4 years ago

I can (somewhat) reproduce this issue on my local machine with 0.13.1rc1, while none of the activities show up in the group's activity feed, although I see them in other places.

jonboiser commented 4 years ago

Ah, this is actually intended behavior, since there is a "Resource type: quizzes" filter active. In that case, we hide the "show more" button, since the behavior is kind of weird (could potentially load 10 more notifications, but none match the filter --> nothing gets added to the list --> confusion).

If you remove the quizzes filter, then click "show more", the 4th notification will show up and remain even after turning on the quizzes filter.

lyw07 commented 4 years ago

ah so we disable show more when there's a filter, so only some latest notifications are shown. Since this is intended behavior, do you think if it would be safe for me to close this issue now? thank you!

jonboiser commented 4 years ago

Let's just keep it open for now, since this seems like a legitimate UX issue.

jonboiser commented 4 years ago

Also, what confused me about why there are only 3 notifications shown upfront is that we actually have a lot more extra "QuizAnswered" notifications that come from the server, but only the first QuizAnswered event for a user+quiz combination is actually shown on the table.

So for the page we're looking at we actually have 10 notifications that get filtered down to 3 shown (2 for Jessica, 1 for Lizdemo), and the "missing" quiz started notification for Lizdemo is actually on the second page of the paginated results.

@nucleogenesis