swipe from left to open side nav on mobile

indirectlylit commented 4 years ago

Observed behavior

Click-to-open on mobile, reported by @jtamiace

A previous work-in-progress PR was opened some time ago here: https://github.com/learningequality/kolibri/pull/8172

Please use this PR as reference for your starting point.
The acceptance criteria that still needs to be met in the previous PR is that this feature should work for both LTR and RTL language support.

Expected behavior

Would be nice to open this menu when swiping from the left edge of the screen

User-facing consequences

Less efficient use on touch-screens

Context

0.13

Pursottam6003 commented 1 year ago

Hii @marcellamaki I would like to work on this issue please assign me the issue i would very happy to contribute

MisRob commented 1 year ago

Hello @Pursottam6003, thank you for your interest. As you volunteered for more issues and already have some of them assigned, I'm leaving this unassigned for now in case someone else wanted to tackle it as you're working on other issues. When your plate is empty, if this issue is still available, please remind yourself here and we can assign it to you.

tanouh commented 7 months ago

Hello, if the issue is still unassigned. I'd be pleased to work on it !

MisRob commented 7 months ago

Hi @tanouh, thanks for volunteering, I will assign you. Note the acceptance criteria in regards to RTL and the related closed PR. This documentation on RTL may come handy - also see the issue with the development server run in hot mode.

MisRob commented 5 months ago

Hi @tanouh, are you still planning to work in this?

rajRishi22 commented 1 week ago

Hi @MisRob , I would like to work on this issue can you please assign me the issue so that i could contribute?

ozer550 commented 1 week ago

Hi @rajRishi22! thanks for volunteering, assigning this to you. if you have any questions on the way feel free to ask here.

Hi @tanouh, thanks for volunteering, I will assign you. Note the acceptance criteria in regards to RTL and the related closed PR. This documentation on RTL may come handy - also see the issue with the development server run in hot mode.

Also referencing this would be helpful.

rajRishi22 commented 5 days ago

Hi @ozer550 , Thanks a lot for assigning me this issue, can you please guide me how to reproduce this issue?

MisRob commented 3 days ago

Hi @rajRishi22, we will get back to you soon with more guidance. Thank you.

MisRob commented 3 days ago

Hi @rajRishi22, so here's some notes to help you:

The easiest way to test swipe gesture would be to use the Chrome devtools device mode. We will also soon add guidance on using the actual phone device, and I will share it with you, but I believe it's not necessary at this stage.
Our former colleague did some progress already. Use https://github.com/learningequality/kolibri/pull/8172 as inspiration or perhaps even draw some code from it. Also read the pull request description and reviewer guidance as it has some useful information.
As you will see in https://github.com/learningequality/kolibri/pull/8172, trying to utilize VueUse useSwipe may be a good start. Use the Chrome devtools device mode to see the swipe gesture in action:
As a first step, make the swipe gesture work for the sidebar in any direction
Then, make sure the gesture works in both LTR and RTL languages. The reason we didn't merge https://github.com/learningequality/kolibri/pull/8172 was that it didn't work for RTL languages yet. Some guidance:
- Understand how RTL works in Kolibri https://kolibri-dev.readthedocs.io/en/develop/i18n.html#rtl-language-support. Feel free to ask questions.
- Don't forget to use yarn run devserver rather than yarn run devsever-hot as soon as you work on RTL support
- After running the development server, for RTL you can switch Kolibri to Arabic language, and for LTR to English, or any other languages of your choice

MisRob commented 2 days ago

Hi @rajRishi22, I think the devtools simulation should do for now, but in case it helps, couple of colleague-friends and me put together a new guide that's available for preview. May be subject to some smaller updates, but we already tried out the main pieces.

learningequality / kolibri