Lookup for some language codes returned by YouTube api fail - Githubissues

learningequality / le-utils

Utilities and constants shared across Kolibri, Ricecooker, and Kolibri Studio

MIT License

2 stars 31 forks source link

Lookup for some language codes returned by YouTube api fail #36

Closed ivanistheone closed 6 years ago

ivanistheone commented 6 years ago

When using YouTubeSubtitleFile, some language codes still fail or are resolved to inaccurate.

Failed: iw (old code for Hebrew), should be he
Possibly inaccurate: zh-Hans (simpflified Chinese) should be zh-CN
Possibly inaccurate: zh-Hant (traditional Chinese) should be zh-TW

Possible workaround

Add special handlers in getlang_by_alpha2 to handle these edge cases.

We can't know know which other non-standard language codes are used by YouTube API so we'll have to implement such fixes on a case by case basis...

ivanistheone commented 6 years ago

This was fixed in #37