learningequality / le-utils

Utilities and constants shared across Kolibri, Ricecooker, and Kolibri Studio
MIT License
3 stars 31 forks source link

setup.py doesn't specify encoding when reading README.md #72

Closed kollivier closed 4 years ago

kollivier commented 4 years ago

In the fallback codepath for reading README.md in setup.py open does not specify an encoding, nor convert the text. This can cause the file to be read in as ASCII, which will error out because the file is encoded in UTF-8 and contains non-ASCII text in it (Français).

There are workarounds, so this is not a huge priority, but it can be confusing because the error can happen when running pip install.

ivanistheone commented 4 years ago

Fixed in https://github.com/learningequality/le-utils/pull/74