search

learningequality / le-utils

Utilities and constants shared across Kolibri, Ricecooker, and Kolibri Studio
MIT License
2 stars 31 forks source link

Python2 and Python3 compatible README.md read #74

Closed Lewiscowles1986 closed 4 years ago

Lewiscowles1986 commented 4 years ago 
Collecting le-utils==0.1.24 (from -r requirements/base.txt (line 18))
  Downloading https://files.pythonhosted.org/packages/f7/5e/e499293c64010ca8e22d126c29b26c3255c41ecc74b7e903e5f1f2a34a54/le-utils-0.1.24.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-wjbv6qqa/le-utils/setup.py", line 3, in <module>
        long_description = open('README.md').read()
      File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 2845: ordinal not in range(128)
Lewiscowles1986 commented 4 years ago

This should make a new release if possible please. This is interfering with Kolibri make docker-whl Makefile target (among other things)

PR will be inbound for that too

ivanistheone commented 4 years ago

le-utils==0.1.25 up on PyPI https://pypi.org/project/le-utils/

thx for the fix!

On Fri, Jul 24, 2020 at 7:46 AM Lewis Cowles notifications@github.com wrote:

This should make a new release if possible please. This is interfering with Kolibri make docker-whl Makefile target (among other things)

PR will be inbound for that too

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/learningequality/le-utils/pull/74#issuecomment-663500107, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABIA7XWPFO6PIDQKBWDENDR5FYA5ANCNFSM4PGUK6SQ .

Lewiscowles1986 commented 4 years ago

I had anticipated more discussion around this. As long as your python2 is 2.7, this should not be an issue.

AFAIK io was backported to ship with 2.7.x.

I used this same fix many years ago when I was into trying to support two major runtimes and this worked for me. I sort of wanted some others to confirm it works for them, although I suppose they can pin to 0.1.24 so it's not the end of the world, it might be a violation of semver.