learningequality / pressurecooker

A library of various media and content processing utilities for use in Ricecooker
MIT License
3 stars 9 forks source link

Add proxy download support and integrate it with YouTube downloads. #48

Closed kollivier closed 4 years ago

ivanistheone commented 4 years ago

Summary of usage:

Changes since last week:

use proxy only for getting metadata

added ignoreerrors = True to options

This avoids erroring out when hitting private/geolocked videos (this results in new problems extract_info returns None or if it's a playlist, the result will have entires a list of None values). We handle those cases by re-raising (a ValueError).

I'm not sure about this change: maybe the de previous behaviour was better --- raise exception rather than try to handle None cases manually. If we get rid of the ignoreerrors = True change these lines won't be necessary https://github.com/learningequality/pressurecooker/blob/008ca2303c6f38dc6ba193ba3485d7d531c67846/pressurecooker/youtube.py#L97-L100

high_resolution=False by default

Defaults to downloading 480 videos, if set high_resolution=True will download 720 videos