Incorrect folders/resources count when moving from the clipboard

radinamatic commented 1 year ago

Observed behavior

While moving a folder with resources from the clipboard to the curator's channel topic tree, the title with summary always stays at 0 folders, 0 resources 👍🏽

incorrect-count-move-from-clipboard

Expected behavior

Title should report the correct number of folders and resources, same as stated at origin (clipboard, 1 folder, 20 resources in the recording above)

User-facing consequences

Uncertainty and confusion about what is being moved from the clipboard.

Errors and logs

Nothing in the console or user-facing.

Steps to reproduce the issue

Select folder/resource in the clipboard
Click on the Move button
Observe the title in the next window

Usage Details

OS: Ubuntu 20.04
Browser: both Firefox and Chromium

radinamatic commented 1 year ago

cc @bjester

bjester commented 1 year ago

@radinamatic This seems to be an existing issue, so I'm going to downgrade this from P0 to remove this as a release blocker.

radinamatic commented 1 year ago

My bad for not remembering that, I thought I searched enough... Agreed it's not a regression then, would the fix be time demanding?

bjester commented 1 year ago

This is still extant. Will take a look

nucleogenesis commented 2 months ago

@LianaHarris360 (cc @marcellamaki @rtibbles) I'm going to leave some notes behind here re: the clipboard issue.

My branch: https://github.com/nucleogenesis/studio/tree/fix--clipbaord-checkboxes-and-numbers I fixed a problem w/ checkboxes here. Without this you'll not be able to select anything in the clipboard

I've done a bunch of digging and have a solid lead on what the issue is but I don't know how to fix it correctly. I'd ask Blaine or Richard if I were coming back to this tomorrow, so it might be worth reaching out there.

Issue: When you select items in your Clipboard and then select the "Move" button, the heading of the page is not calculating the number of resources correctly.

Cause (I think): There are two Vuex modules contentNode and clipboard -- both of them keep "maps" (ie, an object mapping ids to the nodes). The id for nodes in the clipboard/clipboardNodesMap is not being loaded into the contentNode/contentNodesMap . The moveHeader is passing in the ids it gets from the clipboard Vuex module, which are used to look up the node's kind in the contentNode/contentNodesMap but... they're not there.

Some notes:

The clipboard node source_node_id doesn't map to the id of the contentNode/contentNodeMap
The clipboard nodes are not found at all in my IndexedDB -- so perhaps there is something I'm missing altogether there w/ how the backend API would be called?
I think that the solution is to get those clipboard nodes' IDs loaded into the contentNode Vuex store. However I think that if you can just get the kinds for the Clipboard nodes you could do the count within the clipboard components/modules

I hope this helps, thank you for taking this on!

radinamatic commented 1 month ago

Still some hickups with how the folders/resources are calculated to display in the modal title: selected resources are always added into the count for folders. For example:

when I select 2 resources, the title reports 2 folders, 0 resources
when I select a folder with 22 resources, the title reports 23 folders, 0 resources