learningequality / studio

Content curation tools for Kolibri
https://studio.learningequality.org/
MIT License
113 stars 163 forks source link

Import channel search: language filtering requires re-thinking #4389

Open vkWeb opened 9 months ago

vkWeb commented 9 months ago

Observed behavior

Filtering by language in import channel search isn't working as expected.

Expected behavior

Filtering by language should work as expected.

User-facing consequences

Wrong results when filtered by language.

Additional information

Presently, filtering by language in import from channel search uses contentcuration's model's language value. But we set language during publish on exported database. So, filtering by language is giving wrong results.

We need to handle this for both channel types -- public, and private.

Steps to reproduce the issue

  1. Create a channel with a specific language.
  2. Add a resource without setting its language explicitly.
  3. Publish that channel.
  4. Create another channel.
  5. Go to import channel search.
  6. Select My channels from Channels dropdown.
  7. Now, enter a search term that displays that resource.
  8. In the results page, in Language dropdown, select the published channel language.
  9. You will see zero results.

Usage Details

nick2432 commented 9 months ago

Is this issue ready for contribution?

MisRob commented 9 months ago

Hi @nick2432, it's not ready. Please check issues labels - if it has something along the lines that it needs a decisions or design, then it's not ready. You're welcome to tackle other issues, especially the ones marked with "help wanted".