Adds missing string(IMSCP) for HTML5 file type

akolson commented 1 week ago

Summary

Description of the change(s) you made

This PR adds a missing string for the IMSCP variation of the HTML5 file type.

Manual verification steps performed

Select an HTML 5 file
Observe the file upload section for any missing stings

Screenshots (if applicable)

Does this introduce any tech-debt items?

Reviewer guidance

How can a reviewer test these changes?

See manual verification above

References

Fixes #4789

Comments

We will need to do translations for the added string

Contributor's Checklist

PR process:

[ ] If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
[ ] If this includes an internal dependency change, a link to the diff is provided
[ ] The docs label has been added if this introduces a change that needs to be updated in the user docs?
[ ] If any Python requirements have changed, the updated requirements.txt files also included in this PR
[ ] Opportunities for using Google Analytics here are noted
[ ] Migrations are safe for a large db

Studio-specifc:

[ ] All user-facing strings are translated properly
[ ] The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
[ ] All UI components are LTR and RTL compliant
[ ] Views are organized into pages, components, and layouts directories as described in the docs
[ ] Users' storage used is recalculated properly on any changes to main tree files
[ ] If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

[ ] Code is clean and well-commented
[ ] Contributor has fully tested the PR manually
[ ] If there are any front-end changes, before/after screenshots are included
[ ] Critical user journeys are covered by Gherkin stories
[ ] Any new interactions have been added to the QA Sheet
[ ] Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

[ ] Automated test coverage is satisfactory
[ ] PR is fully functional
[ ] PR has been tested for accessibility regressions
[ ] External dependency files were updated if necessary (yarn and pip)
[ ] Documentation is updated
[ ] Contributor is in AUTHORS.md

radinamatic commented 1 week ago

Actually, since I very much doubt IMSCP would have translations in other languages, I'm leaning towards not having this string as translatable at all - let's keep that acronym fixed in all the languages, thoughts?

akolson commented 1 week ago

It looks like that's the case with the other ConstantStrings, so makes sense to me!

bjester commented 1 week ago

@akolson Those constant strings are indeed translated. But if we're not worried about translating the new string, then it should just always show the English text

akolson commented 1 week ago

Closing this to retarget fix to hotfixes https://github.com/learningequality/studio/pull/4818

learningequality / studio