search

learningequality / sushi-chef-khan-academy

Content integration script for the Khan Academy Kolibri channels.
https://www.khanacademy.org/
MIT License
2 stars 10 forks source link

update channel logos #12

Closed indirectlylit closed 4 years ago

indirectlylit commented 5 years ago

Currently we're using various versions of the old logo:

image

We should be using the new one.

Resources:

ivanistheone commented 5 years ago

@ralphiee22 Here are 16:9 images of the logo that could be used for chef:

Force white background: khan-academy-logo__white_bg

[use view image | save as]

indirectlylit commented 5 years ago

that looks fine to me.

Out of curiosity, do we have a guideline indicating that channel thumbnails should have text in them? It seems a bit redundant with the channel name, and then we could just use the graphical part of the logo

kollivier commented 5 years ago

I thought our policy was to use square aspect ratio for the channel icons, and 16:9 for content node icons? Has this changed?

indirectlylit commented 5 years ago

I think the most recent threads were:

kollivier commented 5 years ago

Okay, I'm going to check with @jayoshih about making this change. Right now Studio will crop icons to square on publish. I was going to change that for contentnode thumbnails, but it would actually simplify things if we make it consistently resize to 16:9 for all thumbnails.

indirectlylit commented 5 years ago

Cool. In that thread I'd mentioned having a shared Vue component for consistent rendering of arbitrarily-sized thumbnails within a 16:9 viewport using letterboxing. Let me know if that's a priority and I can try to bang out an initial version.

ivanistheone commented 5 years ago

Updated PR with square-aspect ratio logo. This way currently looks good in Studio. Kolibri adds whitespace on the sides when displaying 16:9 so will also look good in Kolibri too.

I intially went with 16:9 because "primary" logo is VERY wide so would have been too small in square format, but secondary logo is better choice since 1) works well on Studio and Kolibri in current setup, and 2) doesn't duplicate the "Khan Academy" titleing.

ivanistheone commented 4 years ago

This has been fixed for some time now; new runs will use the latest logo. Some of the old logos are still present on channels that haven't been updated recently, but will get phased out over time.