search

learningtapestry / metadataregistry

DEPRECATED - THIS CODE BASE IS NO LONGER MAINTAINED. Metadata Registry
Apache License 2.0
7 stars 4 forks source link

When viewing resource versions, newer and older versions are not visible #53

Open science opened 7 years ago

science commented 7 years ago

Mike from Southern Illinois reports that when viewing a historical version of a record, the older and newer versions of the same document are not returned in the result set.

andersoncardoso commented 7 years ago

@science This behavior is coming from an explicit rule : https://github.com/learningtapestry/metadataregistry/blob/master/app/api/entities/node_headers.rb#L7

I don't know if this was serving some requirement on LR, or if we can remove this now and always show the versions ?

science commented 7 years ago

I recommend that you ask @aspino if this is there for some particular reason? I could see hiding versions for older "leaf node versions" - makes it less confusing.

I'd suggest instead, we expose all versions "above and below" the current version (or just below for head version). For all non-head version, I suggest we add a flag or something that says "isOlderVersion": true or something to the version information - so the developer can't claim ignorance when looking at an older piece of data (vs holding an old head revision document which wouldn't have that).