search

learnk8s / learnk8s.io

https://learnk8s.io
75 stars 31 forks source link

Authenticating microservices requests in Kubernetes #326

Closed amitsaha closed 4 years ago

amitsaha commented 4 years ago

This PR creates the content for the article "Authenticating microservices requests in Kubernetes".

amitsaha commented 4 years ago

I feel like some of these comments are tiny, I can just amend them myself. I'm creating more work for you here. I will raise a PR against your repo with some of the changes. I think we could have saved the back and forth with a local branch. Maybe next time.

Approving, but raising a PR on yours.

Thanks, did you raise a PR already? I cannot see any.

danielepolencic commented 4 years ago

I did not. I think it's easier if you push a local branch and we work together on that

amitsaha commented 4 years ago

Sure. Do you want to merge this PR? Then I can create a branch and push where we can collaborate? Or did you mean something else?

On Wed, 11 Nov 2020, 12:03 pm Daniele Polencic, notifications@github.com wrote:

I did not. I think it's easier if you push a local branch and we work together on that

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/learnk8s/learnk8s.io/pull/326#issuecomment-725061473, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5EVU7MEMLPWYVMMCI5BTSPHPFJANCNFSM4TOENLUA .

danielepolencic commented 4 years ago

We can merge this PR, but then I'm not sure how I will able to comment on it. I think you could push the branch as a local branch. If you can, add the amendments (which otherwise I will have to re-do).

amitsaha commented 4 years ago

On 11 Nov 2020, at 12:33 pm, Daniele Polencic notifications@github.com wrote:

We can merge this PR, but then I'm not sure how I will able to comment on it. I think you could push the branch as a local branch. If you can, add the amendments (which otherwise I will have to re-do).

How about I do this?

  1. I push your suggested amendments to my fork’s branch (same as the PR)
  2. (1) will update the PR automatically

Does that sound close to what you had in mind?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/learnk8s/learnk8s.io/pull/326#issuecomment-725071146, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5EVVEH3MEEIF35Z3WTKTSPHSXLANCNFSM4TOENLUA.

danielepolencic commented 4 years ago

that's ok.

But once you have the changes, can you push the same branch to this repo as well? We close the current PR and raise a local one.

amitsaha commented 4 years ago

Closing this in favor of https://github.com/learnk8s/learnk8s.io/pull/327