learnscripture / learnscripture.net

Source code for https://learnscripture.net
Other
5 stars 2 forks source link

Don't require testing for verses in a passage that are fully learnt. #161

Closed spookylukey closed 1 year ago

spookylukey commented 6 years ago

Created by: spookylukey

Possibly - there is difference of opinion on how this should work.

Removing the tests for these already fully learnt verses could make a big difference to people's review load.

Another option would be to implement #159 (see verse strength before start), so that people are aware the verse is already learnt, and then add an option to the verse menu "skip testing fully learnt verses". After this was clicked, all fully-learnt verses in the section/passage would be reduced to "Read for context", so they are still there, just not tested.

spookylukey commented 6 years ago

Created by: spookylukey

To get this to work properly, the logic in Identity.get_next_section would need overhauling, because it works on the assumption that all verses in a section are tested 'together', and if some verses in a section are not tested, it will keep giving you that section again for testing, instead of the next section. It could possibly be replaced with something simplistic like:

But I need to investigate more.

spookylukey commented 6 years ago

Created by: spookylukey

Plan:

spookylukey commented 6 years ago

Created by: spookylukey

Implemented in 4069809 and 8b7be6a