Use htmx - Githubissues

spookylukey commented 3 years ago

We currently use HTML-Over-The-Wire patterns in a number of places, and some other random bits of jQuery DOM manipulation, many of which can be cleaned up using standard htmx patterns, and the Django ones I've collated in django-htmx-patterns.

[ ] Evaluate enabling hx-boost. See https://github.com/bigskysoftware/htmx/issues/123#issuecomment-734672811 - we could work around this by adding a middleware that rewrites hx-active-element-value to a form value. This works, but there are still issues - some pages (e.g. learn) need to be modified to change how their bootstrapping code identifies the page. History/page title need to be looked at.
[X] Switch from PJAX to HTMX - done in e14ada78
[X] Activity stream - done in 3393918771f6a48065c1b0608f3d204088eeaca9
[X] User activity stream - done in 40df8595e9951f8c325eb49a1f2724e1633ed0c2
[X] User verses page - done in 0fa29117119f0741773c3b6f6a793bdf84c37a5c
[X] Leaderboard page - done in 76d2e2274b0c9bd5d6b39ee15d1ed0aa26c533e4
[X] Choose page - done in 9452cc4d267bc148332a93584822227b43edaa23
[X] Group search - done in ff1ffaf73615c360f6309abdcc30cfd8c26c7ccf
[X] Refactor verse find related code to be easier to switch to HTMX - done in d70ebccf
[ ] Switch VerseFind API and "quick find" controls to HTMX
- [X] "Choose individual" - done in 733aaf5490ca14751203afb2d9f4ddb08d7c697a
- [ ] "Create passage set" page
- [ ] "Create selection set" page
[X] "Add to queue" button - done in 733aaf5490ca14751203afb2d9f4ddb08d7c697a
[X] Follow/unfollow can be done with HTMX - done in fc02706128623b14796c47f5ec96520bfb999c44
[X] HideComment API - done in 406c3e88
[X] AddComment API - done in 5fea2212205e1237e4e9069ecf4b9ae774339c6a
[X] DeleteNotice API - done in 49932b3d3b1b2495a7fbbe670da363daf0067dde
[X] Log out - done in 12bcf32e1b361ca3bc4d40621df5f6026910562b
[ ] versepopup.ts?
[ ] Set preferences modal?

spookylukey commented 3 years ago

unassigned @spookylukey

spookylukey commented 2 years ago

mentioned in commit 7a6c0c37e21ebbb08390b4e699bd27d7a092cafc

spookylukey commented 2 years ago

mentioned in commit b6f3bae66fb53f15ebbad9f6645e0a6b49d030f7

spookylukey commented 2 years ago

mentioned in commit fc02706128623b14796c47f5ec96520bfb999c44

spookylukey commented 2 years ago

marked the checklist item Follow/unfollow can be done with HTMX as completed

spookylukey commented 1 year ago

Some of the patterns we are using could be improved, especially by using inline partials

learnscripture / learnscripture.net

Use htmx #182