Add Spanish support - Githubissues

learnscripture / learnscripture.net

Source code for https://learnscripture.net

Other

5 stars 2 forks source link

Add Spanish support #199

Closed jerivas closed 1 year ago

jerivas commented 1 year ago

[x] Add spanish constants
[x] Add RVG Bible
[ ] Add BES Bible
[ ] Add FTL files
[ ] Translate CMS content
[ ] Anything else @spookylukey?

spookylukey commented 1 year ago

This looks great, the extra cleanups are fine.

For the Spanish constants, ideally we'd also have an addition to make_bible_book_abbreviations which involves creating ES_EXTRA_BOOK_NAMES after the pattern of EN_EXTRA_BOOK_NAMES. This helps people when entering references, otherwise they need the full book name like "1 Tesalonicenses" or "El Cantar de los Cantares" etc.

spookylukey commented 1 year ago

Also, for Bible references, the parser currently assumes:

# Bible references look something like:
# Genesis
# Genesis 1
# Genesis 1:2
# Genesis 1:2-3
# Genesis 1:2-4:5

If there are other alternatives in common in Spanish that you think we should support, please let me know.

spookylukey commented 1 year ago

If you are happy with this, my suggestion is that I go ahead and deploy the RVG, and then do translation of the site as a separate step.

spookylukey commented 1 year ago

Also, I'll put you as a "tester" on learnscripture.net so that you can test the RVG before making it public.

spookylukey commented 1 year ago

I've added RVG online now, you should be able to see it and use it etc. It would be great if you could give it a thorough try out, including setting as your default bible, full text search of verses etc. Then we can switch it to public, and work on other site localization

jerivas commented 1 year ago

Cool! I just tested the following:

Setting RVG as the default Bible, works ok
Went through the Bible 101 set, all verses look good
Passage search (including abbreviations), all good
Full text search. Performed several searches and got the results I expected, including the correct handling of accented characters

The only thing that is missing is the "Choose from word list" learning strategy. When I get to that part in the memorization I get:

On screen testing is not available for this verse in this version. Sorry! Please choose another option in your preferences