search

learntextvis / textkit

Command line tool for manipulating and analyzing text
MIT License
28 stars 6 forks source link

rename `count` to `tokens2counts` ? #21

Closed vlandham closed 8 years ago

vlandham commented 8 years ago

If we think of the addition of counts as a transformation of "tokens" to "tokens + counts" it could make sense to have this function be named tokens2counts.

This would better specify to the end user what the input of this function are, and would keep naming more consistent.

Likewise, the similar POS tagging feature could be named tokens2pos or more confusingly but more accurately tokens2poss (i would vote the former). This would be a transformation of "tokens" to "tokens + pos tags".

Thoughts?

arnicas commented 8 years ago

+1. Good idea. (Also, tokens2pos not poss :)

iros commented 8 years ago

Will rename in my PR!

vlandham commented 8 years ago

woops. i think i stepped on toes - i already did a push to do this change.

Sorry!

On Tue, Apr 5, 2016 at 7:22 AM, Irene Ros notifications@github.com wrote:

Will rename in my PR!

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/learntextvis/textkit/issues/21#issuecomment-205831192