search

learnweb / moodle-mod_collabora

:memo: :globe_with_meridians: An activity for live document editing in Moodle, powered by Collabora Online
GNU General Public License v3.0
8 stars 8 forks source link

Document not accessible after multiple edits #10

Closed koenr closed 4 years ago

koenr commented 4 years ago

Hi, Not sure if it is a CODE-bug or a mod_collabora-bug and hard to narrow down the problem We are facing the following problem: A ods spreadsheet (uploaded - prefilled with data) is edited on a Moodle (latest) server using the moodle-mod_collabora plugin. Both Moodle and collabora run on Ubuntu 18.04 and collabora is installed using .deb packages. The collabora serves a Moodle and a Nextcloud.

We have problems reported from our users, showing a screen where they are offered the option to overwrite, reject or save the file as new document. Neither of them do anything and the user is stuck. image

Other users have reported an ever reloading screen saying that the document has has changed in the repository, again they are stuck. I can't see how the document can be changed in the repository by something else then collabora.

What solves the issue is to restart the loolwsd service on the collabora server.

I notice in the loolwsd journal following warning (lots of them) that might be related: [ docbroker_00e ] WRN LastModifiedTime [2020-03-30T20:26:29+02:00] is in invalid format.. Returning 1585599989000000000| common/Util.cpp:894 [ docbroker_00f ] WRN Invalid or missing JSON in WOPI::PutFile HTTP_OK response.| wsd/Storage.cpp:1079

And occacionally things go completely wrong: broker_012 ] WRN LastModifiedTime [2020-03-31T08:54:25+02:00] is in invalid format.. Returning 1585644865000000000| common/Util.cpp:894 broker_012 ] WRN Client session [155] not found to forward message: o217464 status: type=spreadsheet parts=1 current=0 width=18105 height=111150 viewid=3...| wsd/DocumentBroker.cpp:2073 broker_012 ] WRN Client session [155] not found to forward message: o217467 editor: -1| wsd/DocumentBroker.cpp:2073 broker_012 ] WRN Client session [155] not found to forward message: o217470 curpart: part=0| wsd/DocumentBroker.cpp:2073 broker_012 ] WRN Client session [155] not found to forward message: o217471 setpart: part=0| wsd/DocumentBroker.cpp:2073 broker_012 ] WRN Client session [155] not found to forward message: o217472 disconnected:| wsd/DocumentBroker.cpp:2073 broker_012 ] ERR No socket associated with WebSocketHandler 0x564bbcd9cd30| ./net/WebSocketHandler.hpp:131 broker_013 ] WRN Invalid or missing JSON in WOPI::PutFile HTTP_OK response.| wsd/Storage.cpp:1079 broker_012 ] WRN LastModifiedTime [2020-03-31T08:54:25+02:00] is in invalid format.. Returning 1585644865000000000| common/Util.cpp:894 broker_012 ] WRN Client session [156] not found to forward message: o217550 status: type=spreadsheet parts=1 current=0 width=18105 height=111150 viewid=4...| wsd/DocumentBroker.cpp:2073 broker_012 ] WRN Client session [156] not found to forward message: o217553 editor: -1| wsd/DocumentBroker.cpp:2073 broker_012 ] WRN Client session [156] not found to forward message: o217556 curpart: part=0| wsd/DocumentBroker.cpp:2073 broker_012 ] WRN Client session [156] not found to forward message: o217557 setpart: part=0| wsd/DocumentBroker.cpp:2073 broker_012 ] WRN Client session [156] not found to forward message: o217584 disconnected:| wsd/DocumentBroker.cpp:2073 broker_012 ] ERR No socket associated with WebSocketHandler 0x564bbc9717b0| ./net/WebSocketHandler.hpp:131 lwsd ] SIG frk-13029-13029 2020-03-31 07:14:33.602701 [ forkit ] SIG Shutdown signal received: SIGTERM

_spare_014 ] SIG Shutdown signal received: SIGTERM

Dagefoerde commented 4 years ago

Hi Koen, thanks for reporting. This sounds like a weird bug! Are you in contact with the Collabora people about this?

I can't say what the problem is, either. But I think it must be something on the Collabora side because the Moodle plugin hardly ever interacts with the Collabora plugin. Basically, the only interactions are for opening an editor, for loading, and for storing files.

Sorry that I can't be of more help!

koenr commented 4 years ago

Thank you for your reply, Jan. I really appreciate your view on the problem - good to know not much happens on the Moodle side. I reported the bug against your plugin, because I didn't see the problem in our nextcloud installation. That said, hardly anyone uses it there, since all is synchronised on local disks and there is hardly any concurrent use.

Today there was (actually very shortly after the previous one - a week or so) an update of an awful lot of Collabora libraries. So may be that solves the problem.

Feel free to close the issue as not a bug.

Kind regards Koen

Op wo 1 apr. 2020 om 17:07 schreef Jan notifications@github.com:

Hi Koen, thanks for reporting. This sounds like a weird bug! Are you in contact with the Collabora people about this?

I can't say what the problem is, either. But I think it must be something on the Collabora side because the Moodle plugin hardly ever interacts with the Collabora plugin. Basically, the only interactions are for opening an editor, for loading, and for storing files.

Sorry that I can't be of more help!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/learnweb/moodle-mod_collabora/issues/10#issuecomment-607304943, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWT4BSXDBGE4L2ARBQBMZ3RKNKCJANCNFSM4LXKJMZA .

-- https://mastodon.social/invite/YvCgVX2P

Dagefoerde commented 4 years ago

As long as we don't know what this is, I'd prefer to keep this issue open. Maybe others are experiencing the same problems and can help.

In the meantime, yes, maybe the issue has resolved itself. But in case you see it again, could you maybe check: Does something similar happen when you open a Collabora editor from your Nextcloud? If it does, or if the issue does not persist, I'd close this. Otherwise, if it's Moodle-only, we might have to look into this...

koenr commented 4 years ago

Looking at the release notes on https://www.collaboraoffice.com/collabora-online-3-release-notes/ I notice: "Fix that edits from multiple users got mixed up sometimes" Not pointing to a bug report unfortunately. I wonder if that was it, because I didn't have any problem anymore after the update.

Op do 2 apr. 2020 om 10:55 schreef Jan notifications@github.com:

As long as we don't know what this is, I'd prefer to keep this issue open. Maybe others are experiencing the same problems and can help.

In the meantime, yes, maybe the issue has resolved itself. But in case you see it again, could you maybe check: Does something similar happen when you open a Collabora editor from your Nextcloud? If it does, or if the issue does not persist, I'd close this. Otherwise, if it's Moodle-only, we might have to look into this...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/learnweb/moodle-mod_collabora/issues/10#issuecomment-607713925, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWT4BQA2XVVIU57K4SCFXTRKRHIFANCNFSM4LXKJMZA .

-- https://mastodon.social/invite/YvCgVX2P

Dagefoerde commented 4 years ago

Good to hear that you did not have the issues anymore, though. I now feel confident to close this, but please do report back if the issue resurfaces! Cheers